]> diplodocus.org Git - nmh/log
nmh
9 years agoReplace mh_xmalloc() with mh_xstrdup().
Ralph Corderoy [Mon, 17 Oct 2016 00:26:53 +0000 (01:26 +0100)]
Replace mh_xmalloc() with mh_xstrdup().

9 years agoDelete client_getcpy(); don't know why it exists.
Ralph Corderoy [Sun, 16 Oct 2016 23:32:46 +0000 (00:32 +0100)]
Delete client_getcpy();  don't know why it exists.
Replace with calls to getcpy() or mh_xstrdup().

9 years agoUse mh_xstrdup() instead of getcpy() for a string constant.
Ralph Corderoy [Sun, 16 Oct 2016 23:22:23 +0000 (00:22 +0100)]
Use mh_xstrdup() instead of getcpy() for a string constant.
It cannot be NULL.

9 years agoRewrite getcpy() using mh_x*() allocation functions.
Ralph Corderoy [Sun, 16 Oct 2016 23:08:26 +0000 (00:08 +0100)]
Rewrite getcpy() using mh_x*() allocation functions.

9 years agoAdd const specifier to mh_xstrdup()'s src parameter.
Ralph Corderoy [Sun, 16 Oct 2016 23:07:24 +0000 (00:07 +0100)]
Add const specifier to mh_xstrdup()'s src parameter.

9 years agoRename fmt_compile.c's NEW macro to NEW_FP to avoid redefine.
Ralph Corderoy [Sun, 16 Oct 2016 22:35:35 +0000 (23:35 +0100)]
Rename fmt_compile.c's NEW macro to NEW_FP to avoid redefine.
It grabs and fills in a pointer called `fp' so a more specific name
seems OK.

9 years agoRename local enum to avoid clashing with NEW() macro.
Ralph Corderoy [Sun, 16 Oct 2016 22:16:26 +0000 (23:16 +0100)]
Rename local enum to avoid clashing with NEW() macro.
Even if it doesn't in practice due to the lack of parenthesis, it makes
things more clean if all the enumerates have a common abbreviation
prefix.

9 years agoAdd mh_xstrdup() that exits on allocation failure.
Ralph Corderoy [Sun, 16 Oct 2016 21:53:23 +0000 (22:53 +0100)]
Add mh_xstrdup() that exits on allocation failure.
Call it from a few simple places.

9 years agoAdd NEW(p) that sets p to mh_xmalloc'd memory sized by *p.
Ralph Corderoy [Sun, 16 Oct 2016 18:38:36 +0000 (19:38 +0100)]
Add NEW(p) that sets p to mh_xmalloc'd memory sized by *p.
Use it for the simple cases.  Again, saves having to check the same
identifier is given, possibly far apart after a superfluous cast.

9 years agoAdd macro NEW0(p) that callocs, and use it in simple calls.
Ralph Corderoy [Sun, 16 Oct 2016 17:49:32 +0000 (18:49 +0100)]
Add macro NEW0(p) that callocs, and use it in simple calls.
p is a pointer, the size of the contents of the pointer is allocated
with calloc via mh_xcalloc.  It saves having to check every calloc to
ensure the space requested matches the pointer to which it is assigned.

9 years agoPut parameter names in h/utils.h memory function prototypes.
Ralph Corderoy [Sun, 16 Oct 2016 17:24:51 +0000 (18:24 +0100)]
Put parameter names in h/utils.h memory function prototypes.
It can be a problem if there is a system creeps in a clashing macro,
e.g. `size', but that's unlikely and I think the documentation benefits.

9 years agoAdd mh_xfree(), guarding free(3) from NULLs.
Ralph Corderoy [Sun, 16 Oct 2016 17:21:15 +0000 (18:21 +0100)]
Add mh_xfree(), guarding free(3) from NULLs.
Perhaps all nmh's platforms cope with free(3) these days, but it gives
symmetry with the other mh_x* memory functions and if there is code
testing the pointer before calling free then it can use this instead.

9 years agoTweak mh_xcalloc(); print size on error, follow POSIX.
Ralph Corderoy [Sun, 16 Oct 2016 17:17:31 +0000 (18:17 +0100)]
Tweak mh_xcalloc();  print size on error, follow POSIX.
Using `%zu' for the size_t value.  That might be a problem on older
platforms, but we'll see.  If asked for zero bytes then allocate one to
get a unique pointer.

9 years agoTweak mh_xrealloc(); print size on error, follow POSIX.
Ralph Corderoy [Sun, 16 Oct 2016 17:08:29 +0000 (18:08 +0100)]
Tweak mh_xrealloc();  print size on error, follow POSIX.
Using `%zu' for the size_t value.  That might be a problem on older
platforms, but we'll see.  If asked for zero bytes then free an existing
pointer, only passing it to free(3) if it's non-NULL, and then allocate
a byte so a unique pointer is returned.

9 years agoTweak mh_xmalloc(); print size in error, allocate zero bytes.
Ralph Corderoy [Sun, 16 Oct 2016 16:43:56 +0000 (17:43 +0100)]
Tweak mh_xmalloc();  print size in error, allocate zero bytes.
Using `%zu' for the size_t value.  That might be a problem on older
platforms, but we'll see.  If asked for zero bytes then allocate one
rather than exit;  it's sometimes useful to allocate zero, but some
older platforms might not like it.

9 years agoDon't check mh_xcalloc() and friends for a NULL return.
Ralph Corderoy [Sun, 16 Oct 2016 16:36:03 +0000 (17:36 +0100)]
Don't check mh_xcalloc() and friends for a NULL return.
They never return NULL.  That's their prime purpose.

9 years agoExpand the test of scan's -forma; fails on first attempt.
Ralph Corderoy [Sun, 16 Oct 2016 14:50:12 +0000 (15:50 +0100)]
Expand the test of scan's -forma;  fails on first attempt.
For an email that's just `a:\nb:\nc:\n', a scan with `%{a}\n%{b}\n%{c}'
is one blank line short.  If the `%{c}' has anything added then its line
prints.  Break out of the loop so all the other tests are skipped.

9 years agoDon't test -reverse's boolean on every message number.
Ralph Corderoy [Sun, 16 Oct 2016 14:25:37 +0000 (15:25 +0100)]
Don't test -reverse's boolean on every message number.
Test just once before the loop and define start, end, and increment.
Keep going whilst start is not end.  Happy for underflow or overflow in
calculating end because msgnum will make the same transition.  It can't
affect whether the loop runs at all since 0 is not a valid message
number.

9 years agoUpdate pending-release-notes with a couple of my recent fixes.
Ralph Corderoy [Sun, 16 Oct 2016 13:28:38 +0000 (14:28 +0100)]
Update pending-release-notes with a couple of my recent fixes.

9 years agoFix bug where single-character headers were sometimes missed.
Ralph Corderoy [Sun, 16 Oct 2016 13:19:56 +0000 (14:19 +0100)]
Fix bug where single-character headers were sometimes missed.
The hash function used to check if a header was of interest always used
its first three characters.  For a single-character header that third
byte wasn't particularly set and so it was pot luck if the two hashes
matched, swayed by what was previously in the format string and in the
email's headers.  Alter it to cope, including with an empty string.
Comment that it never gives 127 so leaves the last element of the
hash-table array unused.  Alter test-header-parsing to stop declaring it
expects to fail.

9 years agoChange all Getc() callers to use EOF, not comparisons with 0.
Ralph Corderoy [Sun, 16 Oct 2016 11:44:32 +0000 (12:44 +0100)]
Change all Getc() callers to use EOF, not comparisons with 0.
Makes the logic that bit easier when you don't have to convert to EOF
mentally.  No functional change intended.

9 years agoDon't increment bytes_read if returning EOF.
Ralph Corderoy [Sun, 16 Oct 2016 11:23:57 +0000 (12:23 +0100)]
Don't increment bytes_read if returning EOF.
Don't know if this was actually causing a problem, or if it was wrong,
but bytes_read was always being incremented even if the later test
showed readpos was to be left unincremented and EOF returned instead.
All tests still pass so any breakage must be subtle!

9 years agoFix spelling in comment. Alter case to match identifier.
Ralph Corderoy [Sun, 16 Oct 2016 11:13:59 +0000 (12:13 +0100)]
Fix spelling in comment.  Alter case to match identifier.
vim will search matching case on `*', for example, so if searching for
`\<fdelim\>' the comment shouldn't use `Fdelim'.

9 years agoAdd failing test case for single-character header parsing.
Ralph Corderoy [Sun, 16 Oct 2016 10:43:45 +0000 (11:43 +0100)]
Add failing test case for single-character header parsing.
`scan -format '%{x}'' fails to find single-character header `x' in some
cases, depending on the position of the header in the file.  Add a
simple test case, scan/test-header-parsing, for this that fails.  Alter
the test harness to allow a test to indicate it expects to fail.  When
it does, that's ignored.  If it passes, that's then an error instead.

Did this because I don't know if or when it will be fixed and didn't
want it to be forgotten in the meantime.  When it is fixed, the test can
be enhanced to cover many more possibilities.  First noticed it with ad
hoc testing of my fewer-lseek change, but it is present in the released
1.6.

9 years agoFix spelling in warning message; s/conext/context/.
Ralph Corderoy [Sun, 16 Oct 2016 09:52:39 +0000 (10:52 +0100)]
Fix spelling in warning message;  s/conext/context/.

9 years agoSimply enter_getfld()'s structure, no functional change.
Ralph Corderoy [Sun, 16 Oct 2016 09:13:46 +0000 (10:13 +0100)]
Simply enter_getfld()'s structure, no functional change.
Return ASAP to avoid having to mentally track those states as the code
indents further.

9 years agoExplicitly state a postproc's last argument will be the draft.
Ralph Corderoy [Sun, 16 Oct 2016 08:58:34 +0000 (09:58 +0100)]
Explicitly state a postproc's last argument will be the draft.
Update the sample postproc script to make clear it's the -whom detection
that sucks.

9 years agoDocument fmttest(1)'s existing -help and -version options.
Ralph Corderoy [Sun, 16 Oct 2016 08:35:03 +0000 (09:35 +0100)]
Document fmttest(1)'s existing -help and -version options.

9 years agoMove -help and -version to the front of the man page options.
Ralph Corderoy [Sun, 16 Oct 2016 08:17:51 +0000 (09:17 +0100)]
Move -help and -version to the front of the man page options.
The man pages had -verbose and -help listed at the end of the synopsis.
This put them after mandatory arguments in some cases, e.g. post(8).
Put then at the front, swapping the order so -help is first, as novices
will want to know -help exists early on, and others can simply skip over
them rather than encounter them at the end when they're trying to track
the combinations of what they've read so far.

9 years agoFix end of sentence spacing in man pages, and related problems.
Ralph Corderoy [Sun, 16 Oct 2016 07:52:10 +0000 (08:52 +0100)]
Fix end of sentence spacing in man pages, and related problems.
troff(1) input that ends a sentence at the end of the line gets the
proper inter-sentence spacing when formatted.  If the sentence ends
midline then two spaces must follow to get the same result, otherwise
the spacing looks odd.  Similarly, if a full stop is not the end of a
sentence then it should have the zero-width escape appended so if
re-formatting the source happens to place it at the end of the line then
no large gap follows it: e.g. `e.g.\&'.
Replace `et. al.' with `et al'.

9 years agoReference the buildbot in docs/README.developers.
Ralph Corderoy [Sun, 16 Oct 2016 07:34:35 +0000 (08:34 +0100)]
Reference the buildbot in docs/README.developers.

9 years agoStop one lseek(2) per header fetched by m_getfld.c in common case.
Ralph Corderoy [Sun, 16 Oct 2016 07:23:51 +0000 (08:23 +0100)]
Stop one lseek(2) per header fetched by m_getfld.c in common case.
Only call ftello(3) in enter_getfld() when track_filepos has been
requested;  not often.

9 years agoFix error message when attempting to xmh_realloc() 0 bytes.
Ralph Corderoy [Sat, 15 Oct 2016 22:40:00 +0000 (23:40 +0100)]
Fix error message when attempting to xmh_realloc() 0 bytes.
Though really, I'd expect it to perform a free(3) then, as the real
realloc(3) does.

9 years agoPlugged memory leak in convert_content_charset().
David Levine [Sat, 15 Oct 2016 18:21:13 +0000 (14:21 -0400)]
Plugged memory leak in convert_content_charset().

9 years agoFixed mhshow warn message when it can't convert character set,
David Levine [Sat, 15 Oct 2016 15:53:24 +0000 (11:53 -0400)]
Fixed mhshow warn message when it can't convert character set,
"from" instead of "to", as reported by Ralph.

9 years agoChanged "existant" to "existent". Found by misspell_fixer.
David Levine [Sat, 15 Oct 2016 15:33:34 +0000 (11:33 -0400)]
Changed "existant" to "existent".  Found by misspell_fixer.

9 years agoAdded to convertargs documentation.
David Levine [Sat, 15 Oct 2016 13:58:24 +0000 (09:58 -0400)]
Added to convertargs documentation.

9 years agoTry running script(1) for SHELL test in subshell.
David Levine [Fri, 14 Oct 2016 20:53:27 +0000 (16:53 -0400)]
Try running script(1) for SHELL test in subshell.

9 years agoCheck that script(1) supports SHELL in test-version-check.
David Levine [Fri, 14 Oct 2016 20:40:16 +0000 (16:40 -0400)]
Check that script(1) supports SHELL in test-version-check.

9 years agoAdded check to test-version-check to ensure that script(1) makes
David Levine [Fri, 14 Oct 2016 18:36:21 +0000 (14:36 -0400)]
Added check to test-version-check to ensure that script(1) makes
the program look like it's connected to a terminal.

9 years agoDidn't work on buildbot hosts. Added debug statements.
David Levine [Fri, 14 Oct 2016 17:40:14 +0000 (13:40 -0400)]
Didn't work on buildbot hosts.  Added debug statements.

9 years agoInstead of feeding stdin to script(1) in test-version-check,
David Levine [Fri, 14 Oct 2016 17:27:32 +0000 (13:27 -0400)]
Instead of feeding stdin to script(1) in test-version-check,
create a simple shell script with the command to be run and feed
it to script via the SHELL environment variable or -S option.
Thanks to Ralph for suggesting this approach.  We'll see if it
works on all of the buildbot hosts.

9 years agoTweaked formatting of welcome message.
David Levine [Fri, 14 Oct 2016 13:54:59 +0000 (09:54 -0400)]
Tweaked formatting of welcome message.

9 years agoDisable test-version-check, again, when not connected to terminal.
David Levine [Thu, 13 Oct 2016 23:12:59 +0000 (19:12 -0400)]
Disable test-version-check, again, when not connected to terminal.
I can't otherwise explain why it fails on the ubuntu buildbot.

9 years agoAdded debug printouts to test-version-check.
David Levine [Thu, 13 Oct 2016 22:54:16 +0000 (18:54 -0400)]
Added debug printouts to test-version-check.

9 years agoUse "script file" in test-version-check for maximum portability.
David Levine [Thu, 13 Oct 2016 22:45:06 +0000 (18:45 -0400)]
Use "script file" in test-version-check for maximum portability.
Feed its stdin, which might be problematic.

9 years agoAdded check that replied-to text is not quoted-printable encoded.
David Levine [Thu, 13 Oct 2016 01:48:11 +0000 (21:48 -0400)]
Added check that replied-to text is not quoted-printable encoded.
It's up to the external converter to generate RFC 5322-legal text.

9 years agoSplit ${charset:+-I "$charset"} and another similar case into two
David Levine [Thu, 13 Oct 2016 01:47:16 +0000 (21:47 -0400)]
Split ${charset:+-I "$charset"} and another similar case into two
separate options, because Solaris didn't like the space between them.

9 years agoFor the autoconf/automake stuff to replace getline, the following
Oliver Kiddle [Tue, 11 Oct 2016 14:20:52 +0000 (10:20 -0400)]
For the autoconf/automake stuff to replace getline, the following
patch seems to work.

The final change on configure.ac is to cope with cc -V output having
slightly changed in the most recent version of the compiler.

9 years agoI've written a getline(3) from scratch based on
Ralph Corderoy [Tue, 11 Oct 2016 14:14:14 +0000 (10:14 -0400)]
I've written a getline(3) from scratch based on
https://manned.org/getdelim.3p and am happy for it to have whatever
licence nmh needs.

9 years agoRemoved test-local-mailbox that was mistakenly committed.
David Levine [Tue, 11 Oct 2016 13:31:42 +0000 (09:31 -0400)]
Removed test-local-mailbox that was mistakenly committed.

9 years agoOnly set CFLAGS with gcc.
David Levine [Tue, 11 Oct 2016 12:55:12 +0000 (08:55 -0400)]
Only set CFLAGS with gcc.

9 years agoMoved gcc warning options from AM_CFLAGS back to CFLAGS, to
David Levine [Tue, 11 Oct 2016 12:53:32 +0000 (08:53 -0400)]
Moved gcc warning options from AM_CFLAGS back to CFLAGS, to
make it easier for packagers to override.  This is a partial
rollback of commit f7eb978bd395752d3d9037ea4436b8e2db41f135.

9 years agoAdded LANG to procmail example in mhfixmsg man page.
David Levine [Tue, 11 Oct 2016 12:41:10 +0000 (08:41 -0400)]
Added LANG to procmail example in mhfixmsg man page.

9 years agoCorrected date in forw man page.
David Levine [Mon, 10 Oct 2016 20:43:56 +0000 (16:43 -0400)]
Corrected date in forw man page.

9 years agoTweaked OAuth documentation in mhlogin and send man pages.
David Levine [Mon, 10 Oct 2016 20:42:57 +0000 (16:42 -0400)]
Tweaked OAuth documentation in mhlogin and send man pages.

9 years agoRemoved reference to nmh User's Manual because there is no such
David Levine [Mon, 10 Oct 2016 20:42:20 +0000 (16:42 -0400)]
Removed reference to nmh User's Manual because there is no such
thing.  There was an MH User's Manual, but that is not distributed
with nmh.

9 years agoChanged test suite's require_locale() to set the locale that it
David Levine [Mon, 10 Oct 2016 13:54:51 +0000 (09:54 -0400)]
Changed test suite's require_locale() to set the locale that it
finds, and added upper case versions of locale names to each test.
This should allow the tests to succeed on old Solaris.

9 years agoAdded -sasl to -saslmech xoauth examples in man pages.
David Levine [Sun, 9 Oct 2016 17:59:11 +0000 (13:59 -0400)]
Added -sasl to -saslmech xoauth examples in man pages.

9 years agoReplace `id -u` with $$ so that tests have a chance of working
David Levine [Sat, 8 Oct 2016 02:21:02 +0000 (22:21 -0400)]
Replace `id -u` with $$ so that tests have a chance of working
on old Solaris hosts.

9 years agoAdded comments about sidestepping check for checks to determine
David Levine [Fri, 7 Oct 2016 15:07:03 +0000 (11:07 -0400)]
Added comments about sidestepping check for checks to determine
whether replied-to text needs to be encoded in mhbuildsbr.c.

9 years agoAdded example of decoding RFC-2047 filename to mhstore man page.
David Levine [Fri, 7 Oct 2016 13:40:23 +0000 (09:40 -0400)]
Added example of decoding RFC-2047 filename to mhstore man page.

9 years agoA better fix than e87f37c27828723317a71291e31b34f39ec09098, because
David Levine [Thu, 6 Oct 2016 22:01:50 +0000 (18:01 -0400)]
A better fix than e87f37c27828723317a71291e31b34f39ec09098, because
c_reqencoding should be set for text content in replies if we don't
want it to be encoded.  Scan the text content to see if it is 7- or
8-bit, and set c_reqencoding accordingly.

9 years agoMoved scan_input() from uip/post.c to sbr/utils.c.
David Levine [Thu, 6 Oct 2016 21:53:00 +0000 (17:53 -0400)]
Moved scan_input() from uip/post.c to sbr/utils.c.

9 years agoUpdated test-version-check test_skip message.
David Levine [Thu, 6 Oct 2016 17:10:19 +0000 (13:10 -0400)]
Updated test-version-check test_skip message.

9 years agoFixed test negations in test-version-check to work with make distcheck.
David Levine [Thu, 6 Oct 2016 17:07:20 +0000 (13:07 -0400)]
Fixed test negations in test-version-check to work with make distcheck.

9 years agoOK, don't run test-version-check if not connected to terminal.
David Levine [Thu, 6 Oct 2016 16:57:45 +0000 (12:57 -0400)]
OK, don't run test-version-check if not connected to terminal.

9 years agoMore debugging test-version-check.
David Levine [Thu, 6 Oct 2016 16:47:52 +0000 (12:47 -0400)]
More debugging test-version-check.

9 years agoReplaced strtod() with strtof().
David Levine [Thu, 6 Oct 2016 16:45:52 +0000 (12:45 -0400)]
Replaced strtod() with strtof().

9 years agoMore debugging.
David Levine [Thu, 6 Oct 2016 16:16:53 +0000 (12:16 -0400)]
More debugging.

9 years agoMore test-version-check debugging, on Linux buildbot hosts.
David Levine [Thu, 6 Oct 2016 15:59:24 +0000 (11:59 -0400)]
More test-version-check debugging, on Linux buildbot hosts.

9 years ago1) Use script(1) -t 0 instead of -f on FreeBSD.
David Levine [Thu, 6 Oct 2016 15:47:26 +0000 (11:47 -0400)]
1) Use script(1) -t 0 instead of -f on FreeBSD.
2) Added another debug printout.

9 years agoAccommodate FreeBSD script(1), and add debugging statement to diagnose
David Levine [Thu, 6 Oct 2016 15:30:19 +0000 (11:30 -0400)]
Accommodate FreeBSD script(1), and add debugging statement to diagnose
failure on ubuntu buildbot host.

9 years agoMerge branch 'welcome'
David Levine [Thu, 6 Oct 2016 13:39:27 +0000 (09:39 -0400)]
Merge branch 'welcome'

9 years agoEnable SMTP 8BITMIME for messages with 8-bit content:
David Levine [Thu, 6 Oct 2016 13:11:45 +0000 (09:11 -0400)]
Enable SMTP 8BITMIME for messages with 8-bit content:

1) In post, look for a Content-Transfer-Encoding header.  It has to
   be the header for the message, not any MIME parts.  If found,
   post trusts that it's correct.  If there isn't one, post scans
   the entire message body for any 8-bit bytes.

2) If the message body is 8-bit:
   If the server supports 8BITMIME, enable it.

   If the server doesn't support 8BITMIME, fail with a message to
   user that they need to encode the message for 7-bit transport.

9 years agoCall c_ceclosefnx in mhfixmsg set_ce(). It doesn't seem to help
David Levine [Wed, 5 Oct 2016 20:04:11 +0000 (16:04 -0400)]
Call c_ceclosefnx in mhfixmsg set_ce().  It doesn't seem to help
reduce file descriptor leaks, but can't hurt.

9 years agoDon't set c_reqencoding in repl, let mhbuild set it based on
David Levine [Wed, 5 Oct 2016 20:02:47 +0000 (16:02 -0400)]
Don't set c_reqencoding in repl, let mhbuild set it based on
the content.

9 years agoImprove these comments a bit.
Ken Hornstein [Wed, 5 Oct 2016 02:00:12 +0000 (22:00 -0400)]
Improve these comments a bit.

9 years agoEnabled check for 8-bit content in all text parts, not just those
David Levine [Wed, 5 Oct 2016 01:24:10 +0000 (21:24 -0400)]
Enabled check for 8-bit content in all text parts, not just those
with no specified character set, so that a Content-Transfer-Encoding
header will be added if needed.

9 years agoHave mhfixmsg add a C-T-E at the message level, based on the least
David Levine [Tue, 4 Oct 2016 23:08:42 +0000 (19:08 -0400)]
Have mhfixmsg add a C-T-E at the message level, based on the least
restrictive C-T-E of its parts.

9 years agoBase Content-Transfer-Encoding on decoded and new text parts on
David Levine [Tue, 4 Oct 2016 01:30:14 +0000 (21:30 -0400)]
Base Content-Transfer-Encoding on decoded and new text parts on
content rather than the user's charset.

9 years agoFixed typo.
David Levine [Mon, 3 Oct 2016 21:59:51 +0000 (17:59 -0400)]
Fixed typo.

9 years agoFix C-T-E of message, as well as multipart, types to be 7bit, 8bit,
David Levine [Mon, 3 Oct 2016 21:50:35 +0000 (17:50 -0400)]
Fix C-T-E of message, as well as multipart, types to be 7bit, 8bit,
or binary.

9 years agoAdded test of SMTP server that doesn't support SMTPUTF8.
David Levine [Sun, 2 Oct 2016 13:53:56 +0000 (09:53 -0400)]
Added test of SMTP server that doesn't support SMTPUTF8.

9 years agoFix some typos in the comments.
Ken Hornstein [Sun, 2 Oct 2016 06:05:44 +0000 (02:05 -0400)]
Fix some typos in the comments.

9 years agoMove the read buffer shuffling to BEFORE where we call the network
Ken Hornstein [Sun, 2 Oct 2016 05:47:15 +0000 (01:47 -0400)]
Move the read buffer shuffling to BEFORE where we call the network
read routines; otherwise we can end up calling the lower layers with
a length of zero, which messes everything up.

Also make sure we reshuffle our pointers around if that happens.

9 years agomhfixmsg now replaces RFC 2047 encoding with RFC 2231 encoding of
David Levine [Sat, 1 Oct 2016 18:37:27 +0000 (14:37 -0400)]
mhfixmsg now replaces RFC 2047 encoding with RFC 2231 encoding of
name and filename parameters in Content-Type and Content-Disposition
headers, respectively.

9 years agoCleaned up a bit, mostly in comments for each function.
David Levine [Sat, 1 Oct 2016 16:49:12 +0000 (12:49 -0400)]
Cleaned up a bit, mostly in comments for each function.

9 years agoSigh, the return value from SSL_get_error() isn't suitable to give
Ken Hornstein [Sat, 1 Oct 2016 05:02:34 +0000 (01:02 -0400)]
Sigh, the return value from SSL_get_error() isn't suitable to give
to ERR_get_error(), so use a different function to get the error.

9 years agoPrint even more errors.
Ken Hornstein [Sat, 1 Oct 2016 01:24:43 +0000 (21:24 -0400)]
Print even more errors.

9 years agoAdd -initialtls/-notls flags to msgchk.
Ken Hornstein [Fri, 30 Sep 2016 19:15:08 +0000 (15:15 -0400)]
Add -initialtls/-notls flags to msgchk.

9 years agoMake sure we retry if possible upon a TLS read, and give a more meaningful
Ken Hornstein [Fri, 30 Sep 2016 19:07:03 +0000 (15:07 -0400)]
Make sure we retry if possible upon a TLS read, and give a more meaningful
error if we can't.

9 years agoAdded --sysconfdir to nmh.cygport.
David Levine [Fri, 30 Sep 2016 14:35:06 +0000 (10:35 -0400)]
Added --sysconfdir to nmh.cygport.

9 years agoReplaced some hard-coded strings with variables in nmh.cygport.
David Levine [Fri, 30 Sep 2016 13:18:27 +0000 (09:18 -0400)]
Replaced some hard-coded strings with variables in nmh.cygport.

9 years agoFix typos and drop declaractions of 2 undefined functions.
Eric Gillespie [Fri, 30 Sep 2016 07:55:55 +0000 (00:55 -0700)]
Fix typos and drop declaractions of 2 undefined functions.

9 years agoUpdated comments in h/prototypes.h.
David Levine [Thu, 29 Sep 2016 19:18:02 +0000 (15:18 -0400)]
Updated comments in h/prototypes.h.

9 years agoWelcome message enhancements:
David Levine [Thu, 29 Sep 2016 19:13:05 +0000 (15:13 -0400)]
Welcome message enhancements:
1) Disable if Welcome: disable component is in profile.
2) If MHCONTEXT is set, only print the message if the context file
   already has a Version: reference where the version is old.

9 years agoInstead of relying on invo_name to decide whether to call
David Levine [Thu, 29 Sep 2016 15:40:10 +0000 (11:40 -0400)]
Instead of relying on invo_name to decide whether to call
nmh_version_changed(), use a read_context setting of 1.

9 years agoMake sure stderr is directed to terminal, as well as stdin and
David Levine [Thu, 29 Sep 2016 13:58:27 +0000 (09:58 -0400)]
Make sure stderr is directed to terminal, as well as stdin and
stdout, when deciding whether to check for nmh version update.

9 years agoWait for user to ack new version message.
David Levine [Wed, 28 Sep 2016 22:48:16 +0000 (18:48 -0400)]
Wait for user to ack new version message.