]> diplodocus.org Git - nmh/log
nmh
9 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:20:20 +0000 (23:20 +0100)]
Don't `else' after return.  Simplify control flow.

9 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:20:17 +0000 (23:20 +0100)]
Don't `else' after return.  Simplify control flow.

9 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:20:07 +0000 (23:20 +0100)]
Don't `else' after return.  Simplify control flow.

9 years agoDon't `else' after return or goto. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:19:59 +0000 (23:19 +0100)]
Don't `else' after return or goto.  Simplify control flow.

9 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:19:28 +0000 (23:19 +0100)]
Don't `else' after return.  Simplify control flow.

9 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:18:47 +0000 (23:18 +0100)]
Don't `else' after return.  Simplify control flow.

9 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:16:32 +0000 (23:16 +0100)]
Don't `else' after return.  Simplify control flow.

9 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:16:21 +0000 (23:16 +0100)]
Don't `else' after return.  Simplify control flow.

9 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:15:53 +0000 (23:15 +0100)]
Don't `else' after return.  Simplify control flow.

9 years agoHoist test of search string for NULL out of loop.
Ralph Corderoy [Wed, 19 Oct 2016 23:43:52 +0000 (00:43 +0100)]
Hoist test of search string for NULL out of loop.

9 years agoRototill credentials code so that we only prompt for the username and
Ken Hornstein [Thu, 20 Oct 2016 17:37:29 +0000 (13:37 -0400)]
Rototill credentials code so that we only prompt for the username and
password when it is necessary.

9 years agoAdded locale profile component, value is passed to nmh_init().
David Levine [Wed, 19 Oct 2016 23:53:42 +0000 (19:53 -0400)]
Added locale profile component, value is passed to nmh_init().

9 years agoPass CFLAGS to make distcheck via DISTCHECK_CONFIGURE_FLAGS.
David Levine [Wed, 19 Oct 2016 19:00:56 +0000 (15:00 -0400)]
Pass CFLAGS to make distcheck via DISTCHECK_CONFIGURE_FLAGS.

9 years agoReplace sizeof string constant - 1 with LEN().
Ralph Corderoy [Wed, 19 Oct 2016 23:32:37 +0000 (00:32 +0100)]
Replace sizeof string constant - 1 with LEN().

9 years agoReplace sizeof string constant - 1 with LEN().
Ralph Corderoy [Wed, 19 Oct 2016 23:32:30 +0000 (00:32 +0100)]
Replace sizeof string constant - 1 with LEN().

9 years agoReplace strlen(), malloc(), and sprintf() with concat().
Ralph Corderoy [Wed, 19 Oct 2016 23:24:20 +0000 (00:24 +0100)]
Replace strlen(), malloc(), and sprintf() with concat().

9 years agoUse LEN() on string constants instead of strlen().
Ralph Corderoy [Wed, 19 Oct 2016 23:09:47 +0000 (00:09 +0100)]
Use LEN() on string constants instead of strlen().

9 years agoUse LEN() on string constants instead of strlen().
Ralph Corderoy [Wed, 19 Oct 2016 23:09:47 +0000 (00:09 +0100)]
Use LEN() on string constants instead of strlen().

9 years agoUse LEN() on string constants instead of strlen().
Ralph Corderoy [Wed, 19 Oct 2016 23:09:47 +0000 (00:09 +0100)]
Use LEN() on string constants instead of strlen().

9 years agoAdd LEN(s) definition.
Ralph Corderoy [Wed, 19 Oct 2016 23:08:50 +0000 (00:08 +0100)]
Add LEN(s) definition.
LEN gives the strlen() of string constant s, excluding the
terminating NUL.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 23:02:14 +0000 (00:02 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 23:02:14 +0000 (00:02 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 23:02:14 +0000 (00:02 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 23:02:14 +0000 (00:02 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 23:02:14 +0000 (00:02 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 23:02:14 +0000 (00:02 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 23:02:14 +0000 (00:02 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 23:02:14 +0000 (00:02 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 23:02:14 +0000 (00:02 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 22:38:04 +0000 (23:38 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 22:38:04 +0000 (23:38 +0100)]
Put, rather than print, single characters.

9 years agoPut, rather than print, single characters.
Ralph Corderoy [Wed, 19 Oct 2016 22:38:04 +0000 (23:38 +0100)]
Put, rather than print, single characters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:13 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:13 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:13 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:13 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:13 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace `(char *)0' et al with `NULL'.
Ralph Corderoy [Wed, 19 Oct 2016 22:27:12 +0000 (23:27 +0100)]
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.

9 years agoReplace strlen(), malloc(), and sprintf() with concat().
Ralph Corderoy [Wed, 19 Oct 2016 18:18:48 +0000 (19:18 +0100)]
Replace strlen(), malloc(), and sprintf() with concat().

9 years agoReplace sprintf() with strcpy(); it's no worse.
Ralph Corderoy [Wed, 19 Oct 2016 17:47:30 +0000 (18:47 +0100)]
Replace sprintf() with strcpy();  it's no worse.

9 years agoReplace sprintf() with strcpy(); it's no worse.
Ralph Corderoy [Wed, 19 Oct 2016 17:47:04 +0000 (18:47 +0100)]
Replace sprintf() with strcpy();  it's no worse.

9 years agoAdd comment describing concat().
Ralph Corderoy [Wed, 19 Oct 2016 17:44:58 +0000 (18:44 +0100)]
Add comment describing concat().

9 years agoUse the imperfect snprintf(3) instead of sprintf(3).
Ralph Corderoy [Wed, 19 Oct 2016 17:30:41 +0000 (18:30 +0100)]
Use the imperfect snprintf(3) instead of sprintf(3).

9 years agoUse the imperfect snprintf(3) instead of sprintf(3).
Ralph Corderoy [Wed, 19 Oct 2016 17:29:56 +0000 (18:29 +0100)]
Use the imperfect snprintf(3) instead of sprintf(3).

9 years agoUse the imperfect snprintf(3) instead of sprintf(3).
Ralph Corderoy [Wed, 19 Oct 2016 17:29:43 +0000 (18:29 +0100)]
Use the imperfect snprintf(3) instead of sprintf(3).

9 years agoUse the imperfect snprintf(3) instead of sprintf(3).
Ralph Corderoy [Wed, 19 Oct 2016 17:29:18 +0000 (18:29 +0100)]
Use the imperfect snprintf(3) instead of sprintf(3).

9 years agoAdd EndsWithC(char *s, int c) and call it in some initial places.
Ralph Corderoy [Wed, 19 Oct 2016 17:13:10 +0000 (18:13 +0100)]
Add EndsWithC(char *s, int c) and call it in some initial places.
EndsWithC returns true if non-NULL string s ends with a c before the
terminating NUL.

9 years agoAdd stdbool.h plus fallback to h/nmh.h.
Ralph Corderoy [Wed, 19 Oct 2016 16:52:44 +0000 (17:52 +0100)]
Add stdbool.h plus fallback to h/nmh.h.
Change h/mh.h's FALSE and TRUE to use stdbool.h's.  In time, everything
can switch over and FALSE and TRUE can go.  Delete some local
re-definitions of FALSE and TRUE.

9 years agoFix ruserpass() to not assume `\n' present before trimming.
Ralph Corderoy [Wed, 19 Oct 2016 15:34:05 +0000 (16:34 +0100)]
Fix ruserpass() to not assume `\n' present before trimming.

9 years agoRemoved remaining relics of generated ctypoe-checked.[hc].
David Levine [Wed, 19 Oct 2016 16:09:37 +0000 (12:09 -0400)]
Removed remaining relics of generated ctypoe-checked.[hc].

9 years agoAlter ctype-checked to handle EOF and be hand-written.
Ralph Corderoy [Wed, 19 Oct 2016 14:43:12 +0000 (15:43 +0100)]
Alter ctype-checked to handle EOF and be hand-written.
Along the way, replace the code generation with code that punts the work
onto the stdlib's C functions, needing only a single `identity' array
for all the macros.  A mkdir needed to be added in Makefile.am because
otherwise etc didn't exist in a distcheck and attempting to redirect
stdout to a file in etc failed.  I'm not happy that's the best automake
way to achieve this, i.e. what if another rule attempts to create in etc
first?

9 years agoRemove ./configure's --enable-debug support; it did nothing.
Ralph Corderoy [Wed, 19 Oct 2016 13:39:53 +0000 (14:39 +0100)]
Remove ./configure's --enable-debug support;  it did nothing.
David on nmh-workers said "that looks like a relic that can be removed".

9 years agoDon't recurse in advertise() on writev(2) error, just write(2).
Ralph Corderoy [Wed, 19 Oct 2016 12:04:12 +0000 (13:04 +0100)]
Don't recurse in advertise() on writev(2) error, just write(2).
Some errors, e.g. EPIPE, cause the advise()'s call to another
advertise() to fail again, ad segvinitum when stack busts.  Instead,
snprintf(3) and write(2) that single string, ignoring any error.

9 years agoAdd check-programs target to Makefile.am to add to `make all'.
Ralph Corderoy [Wed, 19 Oct 2016 11:22:47 +0000 (12:22 +0100)]
Add check-programs target to Makefile.am to add to `make all'.

9 years agoIgnore etags ugly TAGS output file.
Ralph Corderoy [Wed, 19 Oct 2016 10:30:55 +0000 (11:30 +0100)]
Ignore etags ugly TAGS output file.
Makefile prefers etags over ctags.

9 years agoReplace strchr() condition with TrimSuffixC(), fixing assumptions.
Ralph Corderoy [Wed, 19 Oct 2016 09:09:47 +0000 (10:09 +0100)]
Replace strchr() condition with TrimSuffixC(), fixing assumptions.
A couple of the existing strchr()-based trims assumed fgets() returned a
string containing `\n' if it didn't return NULL.

9 years agoReplace strchr() condition with TrimSuffixC().
Ralph Corderoy [Wed, 19 Oct 2016 09:06:44 +0000 (10:06 +0100)]
Replace strchr() condition with TrimSuffixC().

9 years agoReplace strchr() condition with TrimSuffixC().
Ralph Corderoy [Wed, 19 Oct 2016 09:06:24 +0000 (10:06 +0100)]
Replace strchr() condition with TrimSuffixC().

9 years agoReplace strchr() condition with TrimSuffixC().
Ralph Corderoy [Wed, 19 Oct 2016 09:04:59 +0000 (10:04 +0100)]
Replace strchr() condition with TrimSuffixC().

9 years agoReplace strchr() condition with TrimSuffixC().
Ralph Corderoy [Wed, 19 Oct 2016 09:04:12 +0000 (10:04 +0100)]
Replace strchr() condition with TrimSuffixC().

9 years agoReplace strchr() condition with TrimSuffixC().
Ralph Corderoy [Wed, 19 Oct 2016 09:03:31 +0000 (10:03 +0100)]
Replace strchr() condition with TrimSuffixC().

9 years agoReplace strchr() condition with TrimSuffixC().
Ralph Corderoy [Tue, 18 Oct 2016 23:50:28 +0000 (00:50 +0100)]
Replace strchr() condition with TrimSuffixC().

9 years agoAdd TrimSuffixC(char *s, int c).
Ralph Corderoy [Tue, 18 Oct 2016 16:05:24 +0000 (17:05 +0100)]
Add TrimSuffixC(char *s, int c).
TrimSuffixC deletes c from the end of non-NULL string s if it's present,
shortening s by 1.  Only one instance of c is removed.

9 years agoWith EAI (mhbuild -headerencoding utf-8), force message header to
David Levine [Tue, 18 Oct 2016 23:55:49 +0000 (19:55 -0400)]
With EAI (mhbuild -headerencoding utf-8), force message header to
show 8-bit UTF-8, even if the message body is ASCII.

9 years agoOutput an error message from post(8) when user specifies
David Levine [Tue, 18 Oct 2016 20:45:30 +0000 (16:45 -0400)]
Output an error message from post(8) when user specifies
mhbuild -headerencoding utf-8 but the SMTP server doesn't
support SMTPUTF8.

9 years agoRewrite r1bindex() using strrchr(3).
Ralph Corderoy [Tue, 18 Oct 2016 15:33:12 +0000 (16:33 +0100)]
Rewrite r1bindex() using strrchr(3).

9 years agoUse concat() in m_putenv. Add FIXME about memory leaks.
Ralph Corderoy [Tue, 18 Oct 2016 15:23:44 +0000 (16:23 +0100)]
Use concat() in m_putenv.  Add FIXME about memory leaks.
POSIX defines setenv(3) and unsetenv(3).  They seem like a good route,
just need to preserve the existing functions' behaviour.

9 years agoShrink the static char[] for "%d" from 8KiB to just right.
Ralph Corderoy [Tue, 18 Oct 2016 15:22:41 +0000 (16:22 +0100)]
Shrink the static char[] for "%d" from 8KiB to just right.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:26 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:25 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:25 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:25 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:25 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:25 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:25 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:25 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:25 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.

9 years agoReplace getcpy() with mh_xstrdup() where the string isn't NULL.
Ralph Corderoy [Tue, 18 Oct 2016 13:52:25 +0000 (14:52 +0100)]
Replace getcpy() with mh_xstrdup() where the string isn't NULL.