Paul Fox [Thu, 29 Nov 2012 18:59:55 +0000 (13:59 -0500)]
show: remove unreachable code
the stanza in question has been impossible to reach for some time. i
believe its purpose was to give a non-mh display proc full pathname
arguments to work with. since we've chdir'd to the folder, giving it
message numbers (i.e., relative pathnames) is fine.
Paul Fox [Tue, 27 Nov 2012 02:00:28 +0000 (21:00 -0500)]
Artificial argv limits.
when i skimmed the code earlier, i was looking at all the uses of
MAXARGS -- many of which are used to size local arrays. converting
them all to be dynamically-sized might be a fair amount of work.
but looking at rmm.c, refile.c, and folder_delmsgs(), i don't think
that issue applies. the patch below fixes the problem, and makes
rmmproc and refile do the right thing (well, at least, the modern
thing). NB: i didn't test to the limit where execvp should return
E2BIG.
as for the rest of mh -- it's certainly possible to hit the MAXARGS
limit with other commands (show, for instance), but i suspect the
frequency is much lower, and those, too, can be fixed as needed.
paul
>From 9636bc0e1697829966f51d2c301cd5d730c38c0a Mon Sep 17 00:00:00 2001
From: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon, 26 Nov 2012 20:49:55 -0500
Subject: [PATCH] rmm/refile: remove the MAXARGS limit when running rmmproc
David Levine [Fri, 23 Nov 2012 15:26:21 +0000 (09:26 -0600)]
slocal used to support two different formats for three of
its arguments:
[address info sender]
[-addr address] [-info data] [-sender sender]
But it hasn't properly supported the first form since at
least April 1999. So, I removed that first form from the
man page and the broken support from the code. Score
another for the test suite!
Ken Hornstein [Thu, 15 Nov 2012 19:21:20 +0000 (14:21 -0500)]
Fix a few bugs:
Make sure to add a ref when adding to the hash table.
Forgot the increment the format array inside of fmt_free().
Marked an allocated string when doing FT_LIT.
David Levine [Wed, 14 Nov 2012 14:47:14 +0000 (08:47 -0600)]
Removed support for zip from sendfiles. I added it as part of the
sendfiles rewrite, f8baa5a34335fc0fc8ccabfabc601d0af73ab769, a few
weeks ago. But because sendfiles fed zip from standard input, zip
would use Zip64 extensions. That would require unzip 6.0 or later
to extract, according to the zip man page. But current MacOS X
uses unzip 5.52, so it broke there.
Ken Hornstein [Tue, 13 Nov 2012 23:53:55 +0000 (18:53 -0500)]
Change %(putlit) and %(zputlit) to take TF_EXPR instead of TF_STR. This
was originally my fault; TF_STR means a string literal as an argument, but
the documentation (and the code) really means for it to take an expression.
David Levine [Wed, 7 Nov 2012 00:43:42 +0000 (18:43 -0600)]
Removed note from BUGS section of several man pages saying
that command line arguments must be quoted for protection from
the shell. That's not a bug, and has nothing to do with nmh.
Changed "back-quoted" to "backquoted" for consistency in a few
man pages.
David Levine [Sun, 28 Oct 2012 18:21:46 +0000 (13:21 -0500)]
Updated build-nmh-cygwin for release of Cygwin nmh 1.5-2. To use:
1) Change VERSION to 1.5-2.
2) make dist
3) Symlink build-nmh-cygwin to nmh-1.5-2 and run that with "all".
David Levine [Sat, 27 Oct 2012 17:18:45 +0000 (12:18 -0500)]
In test-post-common.sh and test-mhmail, wait for fakesmtp to start
for up to 40 seconds. 10 seconds wasn't long enough when I leaned
on my machine. Also, print out a message if exiting due to that
timeout.
David Levine [Sat, 27 Oct 2012 17:14:01 +0000 (12:14 -0500)]
Added -check/-nocheck switches to sortm(1). Also removed obsolete
note in the BUGS portion of its man page about how it sorts messages
that are missing or have an invalid Date: field. It actually sorts
them using their file modification times.
David Levine [Wed, 24 Oct 2012 00:16:56 +0000 (19:16 -0500)]
Cyrus SASL 2.1.25 introduced the sasl_callback_ft prototype,
which has an explicit void parameter list, according to best
practice. So we need to cast to avoid compile warnings.
And provide a sasl_callback_ft prototype for earlier versions.