]> diplodocus.org Git - nmh/log
nmh
10 years agoMove smtp_init's last-ditch attempt for client inside first test.
Ralph Corderoy [Fri, 21 Oct 2016 23:45:09 +0000 (00:45 +0100)]
Move smtp_init's last-ditch attempt for client inside first test.

Didn't realise there was a second lot of similar code before the last
commit.

10 years agoMove smtp_init's last-ditch attempt for client inside first test.
Ralph Corderoy [Fri, 21 Oct 2016 23:41:44 +0000 (00:41 +0100)]
Move smtp_init's last-ditch attempt for client inside first test.

No point checking it twice in a row if it was false the first time.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Fri, 21 Oct 2016 23:40:30 +0000 (00:40 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:27:58 +0000 (00:27 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:27:54 +0000 (00:27 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:27:51 +0000 (00:27 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:27:48 +0000 (00:27 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:27:42 +0000 (00:27 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:27:29 +0000 (00:27 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:27:22 +0000 (00:27 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:27:16 +0000 (00:27 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:26:57 +0000 (00:26 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:26:54 +0000 (00:26 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:26:35 +0000 (00:26 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:26:02 +0000 (00:26 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:25:53 +0000 (00:25 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:21:16 +0000 (00:21 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:20:55 +0000 (00:20 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:20:49 +0000 (00:20 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:20:46 +0000 (00:20 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:18:54 +0000 (00:18 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:18:50 +0000 (00:18 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:18:43 +0000 (00:18 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:18:39 +0000 (00:18 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:18:32 +0000 (00:18 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 23:18:26 +0000 (00:18 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoDon't test boundary in output_content() for NULL; it never is.
Ralph Corderoy [Fri, 21 Oct 2016 23:09:10 +0000 (00:09 +0100)]
Don't test boundary in output_content() for NULL;  it never is.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 22:21:30 +0000 (23:21 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 22:20:41 +0000 (23:20 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 22:20:06 +0000 (23:20 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 22:17:48 +0000 (23:17 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 22:16:11 +0000 (23:16 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 22:15:53 +0000 (23:15 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 22:15:47 +0000 (23:15 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 22:15:32 +0000 (23:15 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoReplace `if (p) free(p)' with `mh_xfree(p)'.
Ralph Corderoy [Fri, 21 Oct 2016 21:01:54 +0000 (22:01 +0100)]
Replace `if (p) free(p)' with `mh_xfree(p)'.

10 years agoAdd FIXME raising if iscntrl(3) test should be based on isprint(3)
Ralph Corderoy [Fri, 21 Oct 2016 20:18:38 +0000 (21:18 +0100)]
Add FIXME raising if iscntrl(3) test should be based on isprint(3)

!iscntrl blocks characters that could be isspace or isblank whereas
isprint would let them through unharmed.

10 years agoAssume POSIX ctype.h; don't vet toupper()'s parameter.
Ralph Corderoy [Fri, 21 Oct 2016 20:18:16 +0000 (21:18 +0100)]
Assume POSIX ctype.h;  don't vet toupper()'s parameter.

10 years agoExplain isascii() test more in netsec_set_sasl_params().
Ralph Corderoy [Fri, 21 Oct 2016 20:14:24 +0000 (21:14 +0100)]
Explain isascii() test more in netsec_set_sasl_params().

It stops non-ASCII lower in the SASL mechanism being uppered, just in
case there is some.

10 years agoAssume POSIX ctype.h; don't vet toupper()'s parameter.
Ralph Corderoy [Fri, 21 Oct 2016 20:10:42 +0000 (21:10 +0100)]
Assume POSIX ctype.h;  don't vet toupper()'s parameter.

10 years agoAssume POSIX ctype.h; don't vet tolower()'s parameter.
Ralph Corderoy [Fri, 21 Oct 2016 19:39:11 +0000 (20:39 +0100)]
Assume POSIX ctype.h;  don't vet tolower()'s parameter.

10 years agoAssume POSIX ctype.h; don't vet tolower()'s parameter.
Ralph Corderoy [Fri, 21 Oct 2016 19:37:32 +0000 (20:37 +0100)]
Assume POSIX ctype.h;  don't vet tolower()'s parameter.

10 years agoOops, stop showbuildenv reading from stdin when run from a TTY.
Ralph Corderoy [Fri, 21 Oct 2016 19:23:55 +0000 (20:23 +0100)]
Oops, stop showbuildenv reading from stdin when run from a TTY.

David spotted the problem I introduced with 8374c3c.  Alter offset to
process any arguments, falling back to stdin if none.

10 years agoAssume POSIX ctype.h; don't vet tolower()'s parameter.
Ralph Corderoy [Fri, 21 Oct 2016 13:42:35 +0000 (14:42 +0100)]
Assume POSIX ctype.h;  don't vet tolower()'s parameter.

10 years agoAssume POSIX ctype.h; don't vet tolower()'s parameter.
Ralph Corderoy [Fri, 21 Oct 2016 13:41:17 +0000 (14:41 +0100)]
Assume POSIX ctype.h;  don't vet tolower()'s parameter.

10 years agoAssume POSIX ctype.h; don't vet tolower()'s parameter.
Ralph Corderoy [Fri, 21 Oct 2016 13:35:47 +0000 (14:35 +0100)]
Assume POSIX ctype.h;  don't vet tolower()'s parameter.

10 years agoFixed MIME parser so it can read binary content.
David Levine [Fri, 21 Oct 2016 17:26:43 +0000 (13:26 -0400)]
Fixed MIME parser so it can read binary content.

Second of two-part fix.  Replaced use of strlen().

10 years agoHave m_getfld() pass back indication of missing blank line.
David Levine [Fri, 21 Oct 2016 17:22:22 +0000 (13:22 -0400)]
Have m_getfld() pass back indication of missing blank line.

This is part one of a two part fix to the MIME parser to
read binary content.  It should have no effect.

Also added start/finish test calls to test-header.

10 years agoFix warnings caused by recent edits; don't mix declarations and code.
Ralph Corderoy [Fri, 21 Oct 2016 08:53:45 +0000 (09:53 +0100)]
Fix warnings caused by recent edits;  don't mix declarations and code.
Quite right too, I prefer all the declarations, codeless, up front.  The
standard -Wall didn't pick this up.  David pointed it out, probably due
to his defaults of `-pedantic -ansi'.

10 years agoDon't `else' after goto. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 23:06:11 +0000 (00:06 +0100)]
Don't `else' after goto.  Simplify control flow.

10 years agoDon't `else' after goto. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 23:06:07 +0000 (00:06 +0100)]
Don't `else' after goto.  Simplify control flow.

10 years agoDon't `else' after goto. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 23:05:50 +0000 (00:05 +0100)]
Don't `else' after goto.  Simplify control flow.

10 years agoDon't `else' after goto. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 23:05:46 +0000 (00:05 +0100)]
Don't `else' after goto.  Simplify control flow.

10 years agoAdded test/mhshow/test-binary. The MIME parser doesn't
David Levine [Thu, 20 Oct 2016 23:38:01 +0000 (19:38 -0400)]
Added test/mhshow/test-binary.  The MIME parser doesn't
properly handle null bytes because it uses getline().

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:57:56 +0000 (23:57 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:57:09 +0000 (23:57 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:30:39 +0000 (23:30 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:30:07 +0000 (23:30 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:30:02 +0000 (23:30 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:29:56 +0000 (23:29 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:29:49 +0000 (23:29 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:29:46 +0000 (23:29 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:29:35 +0000 (23:29 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:29:19 +0000 (23:29 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:27:42 +0000 (23:27 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:27:37 +0000 (23:27 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:27:21 +0000 (23:27 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:27:08 +0000 (23:27 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:27:05 +0000 (23:27 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:23:46 +0000 (23:23 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:23:41 +0000 (23:23 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:23:38 +0000 (23:23 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:23:35 +0000 (23:23 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:23:28 +0000 (23:23 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:23:00 +0000 (23:23 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:22:21 +0000 (23:22 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:22:15 +0000 (23:22 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:22:11 +0000 (23:22 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:22:04 +0000 (23:22 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:22:00 +0000 (23:22 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:21:45 +0000 (23:21 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:21:34 +0000 (23:21 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:21:05 +0000 (23:21 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:20:25 +0000 (23:20 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:20:20 +0000 (23:20 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:20:17 +0000 (23:20 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:20:07 +0000 (23:20 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return or goto. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:19:59 +0000 (23:19 +0100)]
Don't `else' after return or goto.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:19:28 +0000 (23:19 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:18:47 +0000 (23:18 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:16:32 +0000 (23:16 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:16:21 +0000 (23:16 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoDon't `else' after return. Simplify control flow.
Ralph Corderoy [Thu, 20 Oct 2016 22:15:53 +0000 (23:15 +0100)]
Don't `else' after return.  Simplify control flow.

10 years agoHoist test of search string for NULL out of loop.
Ralph Corderoy [Wed, 19 Oct 2016 23:43:52 +0000 (00:43 +0100)]
Hoist test of search string for NULL out of loop.

10 years agoRototill credentials code so that we only prompt for the username and
Ken Hornstein [Thu, 20 Oct 2016 17:37:29 +0000 (13:37 -0400)]
Rototill credentials code so that we only prompt for the username and
password when it is necessary.

10 years agoAdded locale profile component, value is passed to nmh_init().
David Levine [Wed, 19 Oct 2016 23:53:42 +0000 (19:53 -0400)]
Added locale profile component, value is passed to nmh_init().

10 years agoPass CFLAGS to make distcheck via DISTCHECK_CONFIGURE_FLAGS.
David Levine [Wed, 19 Oct 2016 19:00:56 +0000 (15:00 -0400)]
Pass CFLAGS to make distcheck via DISTCHECK_CONFIGURE_FLAGS.

10 years agoReplace sizeof string constant - 1 with LEN().
Ralph Corderoy [Wed, 19 Oct 2016 23:32:37 +0000 (00:32 +0100)]
Replace sizeof string constant - 1 with LEN().

10 years agoReplace sizeof string constant - 1 with LEN().
Ralph Corderoy [Wed, 19 Oct 2016 23:32:30 +0000 (00:32 +0100)]
Replace sizeof string constant - 1 with LEN().

10 years agoReplace strlen(), malloc(), and sprintf() with concat().
Ralph Corderoy [Wed, 19 Oct 2016 23:24:20 +0000 (00:24 +0100)]
Replace strlen(), malloc(), and sprintf() with concat().