]> diplodocus.org Git - nmh/log
nmh
10 years agoUpdate documentation a bit.
Ken Hornstein [Fri, 23 Sep 2016 18:22:29 +0000 (14:22 -0400)]
Update documentation a bit.

10 years agoWhoops, a typo from the last merge; when the one variable got
Ken Hornstein [Fri, 23 Sep 2016 18:21:23 +0000 (14:21 -0400)]
Whoops, a typo from the last merge; when the one variable got
reformatted continuation escapes weren't included.

10 years agoMerge branch 'pop-tls'
Ken Hornstein [Fri, 23 Sep 2016 18:14:26 +0000 (14:14 -0400)]
Merge branch 'pop-tls'

10 years agoDon't output snoop information when doing RETR or TOP.
Ken Hornstein [Fri, 23 Sep 2016 18:13:23 +0000 (14:13 -0400)]
Don't output snoop information when doing RETR or TOP.

10 years agoSwitch decodeBase64() second argument to an unsigned char **.
Ken Hornstein [Fri, 23 Sep 2016 18:00:59 +0000 (14:00 -0400)]
Switch decodeBase64() second argument to an unsigned char **.

10 years agoDon't always output a decoded SASL token; if it's a large binary blob, just
Ken Hornstein [Fri, 23 Sep 2016 17:59:52 +0000 (13:59 -0400)]
Don't always output a decoded SASL token; if it's a large binary blob, just
stick with the base64 output.

10 years agoRearranged statements to avoid compile warning about mixed
David Levine [Fri, 23 Sep 2016 12:21:57 +0000 (08:21 -0400)]
Rearranged statements to avoid compile warning about mixed
declarations and code.

10 years agoFixed typo (NOTLSSW).
David Levine [Fri, 23 Sep 2016 12:20:27 +0000 (08:20 -0400)]
Fixed typo (NOTLSSW).

10 years agoGarbage collect the saslmaxssf flag, and update documentation for
Ken Hornstein [Fri, 23 Sep 2016 03:27:36 +0000 (23:27 -0400)]
Garbage collect the saslmaxssf flag, and update documentation for
new -initialtls flag and -notls flags for inc.

10 years agoForgot to reset the snoop callback one time.
Ken Hornstein [Fri, 23 Sep 2016 03:10:59 +0000 (23:10 -0400)]
Forgot to reset the snoop callback one time.

10 years agoFix some typos and warnings.
Ken Hornstein [Fri, 23 Sep 2016 01:26:39 +0000 (21:26 -0400)]
Fix some typos and warnings.

10 years agoSwitched to "server" instead of "client" for SASL remote hostname.
Ken Hornstein [Fri, 23 Sep 2016 00:01:34 +0000 (20:01 -0400)]
Switched to "server" instead of "client" for SASL remote hostname.

10 years agoGarbage collect unused code.
Ken Hornstein [Thu, 22 Sep 2016 23:31:57 +0000 (19:31 -0400)]
Garbage collect unused code.

10 years agoWhoops, turns out I originally ran this test with XOAUTH set. Fix the
Ken Hornstein [Thu, 22 Sep 2016 23:24:50 +0000 (19:24 -0400)]
Whoops, turns out I originally ran this test with XOAUTH set.  Fix the
output and make sure the common script unsets XOAUTH so this doesn't
happen again.

10 years agoChange the tests to make them work with the new program output
Ken Hornstein [Thu, 22 Sep 2016 23:12:36 +0000 (19:12 -0400)]
Change the tests to make them work with the new program output
and slight change in the interface.

10 years agoAdd error reporting for one case, and move around the return code
Ken Hornstein [Thu, 22 Sep 2016 23:12:12 +0000 (19:12 -0400)]
Add error reporting for one case, and move around the return code
in the SASL callback a bit.

10 years agoAdd the SASL callback; things work now!
Ken Hornstein [Thu, 22 Sep 2016 23:11:32 +0000 (19:11 -0400)]
Add the SASL callback; things work now!

10 years agoDisable the original call to BIO_flush() now that we're doing our
Ken Hornstein [Thu, 22 Sep 2016 23:10:23 +0000 (19:10 -0400)]
Disable the original call to BIO_flush() now that we're doing our
own buffering.

10 years agoI had forgotten that nesec_set_tls() has to be called AFTER the
Ken Hornstein [Thu, 22 Sep 2016 23:05:39 +0000 (19:05 -0400)]
I had forgotten that nesec_set_tls() has to be called AFTER the
descriptors are set.

10 years agoFixed test-mhfixmsg by using octal instead of hex bytes with
David Levine [Thu, 22 Sep 2016 18:08:10 +0000 (14:08 -0400)]
Fixed test-mhfixmsg by using octal instead of hex bytes with
printf(1).

10 years agoRemoved temporary debuggin printout.
David Levine [Thu, 22 Sep 2016 17:54:50 +0000 (13:54 -0400)]
Removed temporary debuggin printout.

10 years agoAdded start_test/finish_test.
David Levine [Thu, 22 Sep 2016 17:39:55 +0000 (13:39 -0400)]
Added start_test/finish_test.

10 years agoAdded temporary diagnostic printout.
David Levine [Thu, 22 Sep 2016 17:39:42 +0000 (13:39 -0400)]
Added temporary diagnostic printout.

10 years agoAllow -decodetext binary, though 8bit is still the default because
David Levine [Thu, 22 Sep 2016 17:07:32 +0000 (13:07 -0400)]
Allow -decodetext binary, though 8bit is still the default because
binary can produce messages that are not RFC 2045 compliant.

10 years agoSpecify full path to mhl in test because it might not be on PATH.
David Levine [Thu, 22 Sep 2016 12:24:49 +0000 (08:24 -0400)]
Specify full path to mhl in test because it might not be on PATH.

10 years agoAlright, things compile now, but don't link yet; need to write the
Ken Hornstein [Thu, 22 Sep 2016 04:05:13 +0000 (00:05 -0400)]
Alright, things compile now, but don't link yet; need to write the
SMTP sasl callback.

10 years agoOkay, fixed a few more things. Almost there?
Ken Hornstein [Thu, 22 Sep 2016 04:04:43 +0000 (00:04 -0400)]
Okay, fixed a few more things.  Almost there?

10 years agoMerge branch 'pop-tls' of git.sv.gnu.org:/srv/git/nmh into pop-tls
Ken Hornstein [Thu, 22 Sep 2016 03:33:29 +0000 (23:33 -0400)]
Merge branch 'pop-tls' of git.sv.gnu.org:/srv/git/nmh into pop-tls

10 years agoChange things so we can take two file descriptors, one for input
Ken Hornstein [Thu, 22 Sep 2016 03:32:11 +0000 (23:32 -0400)]
Change things so we can take two file descriptors, one for input
and one for output.

10 years agoOkay! Squashed a few bugs, now have POP OAuth tests working.
Ken Hornstein [Wed, 21 Sep 2016 20:51:21 +0000 (16:51 -0400)]
Okay!  Squashed a few bugs, now have POP OAuth tests working.

10 years agoFixed test-rfc6532: MIME-Version isn't ignored by mhl.headers.
David Levine [Wed, 21 Sep 2016 17:49:21 +0000 (13:49 -0400)]
Fixed test-rfc6532:  MIME-Version isn't ignored by mhl.headers.
Maybe it should be?

10 years agoAdded test/mhl/test-rfc6532.
David Levine [Wed, 21 Sep 2016 15:54:49 +0000 (11:54 -0400)]
Added test/mhl/test-rfc6532.

10 years agoAdd support for a base64-decoding snoop callback.
Ken Hornstein [Wed, 21 Sep 2016 04:06:52 +0000 (00:06 -0400)]
Add support for a base64-decoding snoop callback.

10 years agoGarbage-collect all of this unused code.
Ken Hornstein [Wed, 21 Sep 2016 03:30:51 +0000 (23:30 -0400)]
Garbage-collect all of this unused code.

10 years agoWe have OAauth working! But the tests don't work yet.
Ken Hornstein [Wed, 21 Sep 2016 02:11:25 +0000 (22:11 -0400)]
We have OAauth working!  But the tests don't work yet.

10 years agoShuffle some stuff around, change some prototypes, and modify the
Ken Hornstein [Wed, 21 Sep 2016 00:09:37 +0000 (20:09 -0400)]
Shuffle some stuff around, change some prototypes, and modify the
oauth code a bit to fit our new structure.

10 years agoPlugged memory leak in openBase64().
David Levine [Tue, 20 Sep 2016 16:23:04 +0000 (12:23 -0400)]
Plugged memory leak in openBase64().

10 years agoMaybe ... it works? Sort of! Needs more testing, and for me to finish
Ken Hornstein [Tue, 20 Sep 2016 03:29:39 +0000 (23:29 -0400)]
Maybe ... it works?  Sort of!  Needs more testing, and for me to finish
OAuth support.

10 years agoMore work, but not there just yet.
Ken Hornstein [Mon, 19 Sep 2016 23:59:40 +0000 (19:59 -0400)]
More work, but not there just yet.

10 years agoOkay, we're finally getting to implementation stage! Hopefully we'll be
Ken Hornstein [Mon, 19 Sep 2016 02:03:18 +0000 (22:03 -0400)]
Okay, we're finally getting to implementation stage!  Hopefully we'll be
able to make it all work with POP first, then SMTP.

10 years agoMoved LDFLAGS to AM_LDFLAGS.
David Levine [Sun, 18 Sep 2016 16:22:10 +0000 (12:22 -0400)]
Moved LDFLAGS to AM_LDFLAGS.

10 years agoMoved CFLAGS additions to AM_CFLAGS.
David Levine [Sun, 18 Sep 2016 14:29:17 +0000 (10:29 -0400)]
Moved CFLAGS additions to AM_CFLAGS.

10 years agoMoved restore of CFLAGS outside of AC_CHECK_HEADER, so that it's done
David Levine [Sun, 18 Sep 2016 13:57:06 +0000 (09:57 -0400)]
Moved restore of CFLAGS outside of AC_CHECK_HEADER, so that it's done
unconditionally.

10 years agoI think I've written all of these functions; now we just need to
Ken Hornstein [Sun, 18 Sep 2016 05:15:20 +0000 (01:15 -0400)]
I think I've written all of these functions; now we just need to
have everyone else use them.

10 years agoAdded AM_CPPFLAGS to CFLAGS that are used for curl checks, because
David Levine [Sat, 17 Sep 2016 21:11:23 +0000 (17:11 -0400)]
Added AM_CPPFLAGS to CFLAGS that are used for curl checks, because
they're needed on Cygwin.  (Without _GNU_SOURCE, sys/types.h doesn't
include sys/select.h.)  Also added AM_CFLAGS, which we don't currently
use but might in the future.

10 years agoUpdated Makefile.am to correspond to file replacement in commit
David Levine [Sat, 17 Sep 2016 14:15:11 +0000 (10:15 -0400)]
Updated Makefile.am to correspond to file replacement in commit
4a007bacfa67e69923b15500e2b2c3a6bcde541a.

10 years agoUpdated cygport script in preparation for nmh 1.7 release.
David Levine [Sat, 17 Sep 2016 14:08:22 +0000 (10:08 -0400)]
Updated cygport script in preparation for nmh 1.7 release.

10 years agoReplaced cygwin build script with cygport script.
David Levine [Sat, 17 Sep 2016 14:06:56 +0000 (10:06 -0400)]
Replaced cygwin build script with cygport script.

10 years agoAdded libcurl to Cygwin package requirements, if configured
David Levine [Sat, 17 Sep 2016 14:05:35 +0000 (10:05 -0400)]
Added libcurl to Cygwin package requirements, if configured
with --with-oauth.

10 years agoAdded oauth to mhparam examples.
David Levine [Fri, 16 Sep 2016 21:47:31 +0000 (17:47 -0400)]
Added oauth to mhparam examples.

10 years agoStill closer, but not quite there yet.
Ken Hornstein [Fri, 16 Sep 2016 19:59:27 +0000 (15:59 -0400)]
Still closer, but not quite there yet.

10 years agoMoved LFLAGS additions to AM_LFLAGS.
David Levine [Fri, 16 Sep 2016 16:08:55 +0000 (12:08 -0400)]
Moved LFLAGS additions to AM_LFLAGS.

10 years agoUse CPPFLAGS instead of AM_CPPFLAGS for FreeBSD additions.
David Levine [Fri, 16 Sep 2016 15:56:42 +0000 (11:56 -0400)]
Use CPPFLAGS instead of AM_CPPFLAGS for FreeBSD additions.
Otherwise, it will miss -liconv.  I think.

10 years agoCleaned up cppflags.m4 a bit and fixed its mode.
David Levine [Fri, 16 Sep 2016 15:15:45 +0000 (11:15 -0400)]
Cleaned up cppflags.m4 a bit and fixed its mode.

10 years agoMoved CPPFLAGS additions to AM_CPPFLAGS.
David Levine [Fri, 16 Sep 2016 12:28:18 +0000 (08:28 -0400)]
Moved CPPFLAGS additions to AM_CPPFLAGS.

10 years agoOkay, a bit closer.
Ken Hornstein [Fri, 16 Sep 2016 02:36:17 +0000 (22:36 -0400)]
Okay, a bit closer.

10 years agoAdded 2 second timeout to curl command in post() in oauth.c, for
David Levine [Fri, 16 Sep 2016 00:00:02 +0000 (20:00 -0400)]
Added 2 second timeout to curl command in post() in oauth.c, for
localhost requests only, because the default timeout on Cygwin is 5
minutes.

10 years agoAdded NMH_ADDL_CPPFLAGS macro in new m4/cppflags.m4, to remove
David Levine [Thu, 15 Sep 2016 22:58:14 +0000 (18:58 -0400)]
Added NMH_ADDL_CPPFLAGS macro in new m4/cppflags.m4, to remove
explicit OS dependencies when deciding whether -DGNU_SOURCE is
needed.  (Cygwin now needs it.)

10 years agoFleshed out some more, but we're not there just yet.
Ken Hornstein [Thu, 15 Sep 2016 20:00:07 +0000 (16:00 -0400)]
Fleshed out some more, but we're not there just yet.

10 years agoA bit more code.
Ken Hornstein [Wed, 14 Sep 2016 04:00:48 +0000 (00:00 -0400)]
A bit more code.

10 years agoSave this for now.
Ken Hornstein [Tue, 13 Sep 2016 20:00:46 +0000 (16:00 -0400)]
Save this for now.

10 years agoMore functions documented.
Ken Hornstein [Tue, 13 Sep 2016 01:37:06 +0000 (21:37 -0400)]
More functions documented.

10 years agoBeginnings of a new library API.
Ken Hornstein [Mon, 12 Sep 2016 23:07:29 +0000 (19:07 -0400)]
Beginnings of a new library API.

10 years agoExposed a bunch of switches that are now documented.
David Levine [Sun, 11 Sep 2016 15:49:44 +0000 (11:49 -0400)]
Exposed a bunch of switches that are now documented.

10 years agoAdded Examples section to mhlogin man page.
David Levine [Sun, 11 Sep 2016 15:30:42 +0000 (11:30 -0400)]
Added Examples section to mhlogin man page.

10 years agoAdd a "file-nopermcheck" credential entry.
Ken Hornstein [Sun, 11 Sep 2016 04:41:18 +0000 (00:41 -0400)]
Add a "file-nopermcheck" credential entry.

10 years agoChange this so the MTS_SMTP is the default, to match the value
Ken Hornstein [Sun, 11 Sep 2016 04:05:25 +0000 (00:05 -0400)]
Change this so the MTS_SMTP is the default, to match the value
of mts_method and the original code.

10 years agoRemove the unused argument from mts_init() (as far as I can tell,
Ken Hornstein [Sun, 11 Sep 2016 04:01:28 +0000 (00:01 -0400)]
Remove the unused argument from mts_init() (as far as I can tell,
it has never been used, for anything).

10 years agoCloser, but not there yet.
Ken Hornstein [Fri, 9 Sep 2016 19:49:26 +0000 (15:49 -0400)]
Closer, but not there yet.

10 years agoStarted ... not quite working yet.
Ken Hornstein [Thu, 8 Sep 2016 19:40:04 +0000 (15:40 -0400)]
Started ... not quite working yet.

10 years agoOnly get a write lock on the sequences file if we're performing a pack
Ken Hornstein [Thu, 8 Sep 2016 17:13:57 +0000 (13:13 -0400)]
Only get a write lock on the sequences file if we're performing a pack
operation.

10 years agoAdded some NMH_UNUSED's to prevent compile warnings without
David Levine [Tue, 6 Sep 2016 22:02:46 +0000 (18:02 -0400)]
Added some NMH_UNUSED's to prevent compile warnings without
OAUTH_SUPPORT.

10 years agoProtected call of mh_oauth_do_xoauth() with #ifdef OAUTH_SUPPORT to
David Levine [Tue, 6 Sep 2016 21:49:59 +0000 (17:49 -0400)]
Protected call of mh_oauth_do_xoauth() with #ifdef OAUTH_SUPPORT to
allow post(1) to link when configured without it.

10 years agoProtected use of setup_oauth_params() with #ifdef OAUTH_SUPPORT.
David Levine [Tue, 6 Sep 2016 21:36:16 +0000 (17:36 -0400)]
Protected use of setup_oauth_params() with #ifdef OAUTH_SUPPORT.

10 years agoUnder some circumstances, some version of MacOS X can return EPROTOTYPE
Ken Hornstein [Tue, 6 Sep 2016 19:32:28 +0000 (15:32 -0400)]
Under some circumstances, some version of MacOS X can return EPROTOTYPE
if you try to write to a connection that is being torn down.  Handle
that case.

10 years agoRemoved incorrect increment of read position pointer, which caused
David Levine [Tue, 6 Sep 2016 13:16:15 +0000 (09:16 -0400)]
Removed incorrect increment of read position pointer, which caused
first character of some very short (less than 4 characters) message
bodies to be dropped.  It seems that the message needed to start
with a "From " line to reveal the problem.

10 years agoMerge branch 'xoauth'
Ken Hornstein [Tue, 6 Sep 2016 00:32:03 +0000 (20:32 -0400)]
Merge branch 'xoauth'

10 years agoChange things so if -authservice wasn't given, throw an error.
Ken Hornstein [Tue, 6 Sep 2016 00:21:55 +0000 (20:21 -0400)]
Change things so if -authservice wasn't given, throw an error.
At the same time, improve the code so -authservice doesn't
have to be given before the other oauth flags.

10 years agoSwitch from our horrible awk script that parses the signal header file
Ken Hornstein [Mon, 5 Sep 2016 02:20:40 +0000 (22:20 -0400)]
Switch from our horrible awk script that parses the signal header file
to the POSIX function strsignal().

10 years agoFix up a few minor nits to make OAuth2 (finally!) work right in post(8).
Ken Hornstein [Mon, 5 Sep 2016 00:42:21 +0000 (20:42 -0400)]
Fix up a few minor nits to make OAuth2 (finally!) work right in post(8).
Change the tests to support the new error output.

10 years agoAdd new signal include file location for El Capitan. I am not sure
Ken Hornstein [Sun, 4 Sep 2016 03:46:45 +0000 (23:46 -0400)]
Add new signal include file location for El Capitan.  I am not sure
this is in general the right approach.

10 years agoAdded warning message on stderr if folder -nocreate is provided
David Levine [Mon, 29 Aug 2016 13:26:38 +0000 (09:26 -0400)]
Added warning message on stderr if folder -nocreate is provided
a non-existant folder.

(cherry picked from commit d51964a51fdc08d92dab9825a8357c9adba34aa7)

10 years agoAdded warning message on stderr if folder -nocreate is provided
David Levine [Mon, 29 Aug 2016 13:26:38 +0000 (09:26 -0400)]
Added warning message on stderr if folder -nocreate is provided
a non-existant folder.

10 years agoRemoved jsmn license from COPYRIGHT. In keeping what appears to
David Levine [Sun, 21 Aug 2016 17:04:59 +0000 (13:04 -0400)]
Removed jsmn license from COPYRIGHT.  In keeping what appears to
be standard practice, the COPYRIGHT file just contains the nmh
copyright.  We retain the jsmn license in thirdparty/jsmn/LICENSE.

10 years agoCheck result of setup_oauth_params() for != OK instead of non-zero.
David Levine [Sun, 21 Aug 2016 16:22:42 +0000 (12:22 -0400)]
Check result of setup_oauth_params() for != OK instead of non-zero.

10 years agoVery close, but it doesn't passes the tests just yet.
Ken Hornstein [Sun, 21 Aug 2016 04:39:36 +0000 (00:39 -0400)]
Very close, but it doesn't passes the tests just yet.

10 years agoRetrieve appropriate profile entries and pass them to post(8).
Ken Hornstein [Sat, 20 Aug 2016 05:18:13 +0000 (01:18 -0400)]
Retrieve appropriate profile entries and pass them to post(8).
Not quite working yet.

10 years agoStart of adding arguments for transmitting OAuth parameters to
Ken Hornstein [Wed, 17 Aug 2016 03:35:09 +0000 (23:35 -0400)]
Start of adding arguments for transmitting OAuth parameters to
post.

(cherry picked from commit 68246559a5087f3a3c13ef2a6240a7c18dd9c155)

10 years agoStart of adding arguments for transmitting OAuth parameters to
Ken Hornstein [Wed, 17 Aug 2016 03:35:09 +0000 (23:35 -0400)]
Start of adding arguments for transmitting OAuth parameters to
post.

10 years agoAdd $(ICONVLIB) to programs that need it.
Ken Hornstein [Mon, 15 Aug 2016 18:39:04 +0000 (14:39 -0400)]
Add $(ICONVLIB) to programs that need it.

(cherry picked from commit 8c9441dc98bb4ce98ae70528d5415d9f5507713e)

10 years agoAdd $(ICONVLIB) to programs that need it.
Ken Hornstein [Mon, 15 Aug 2016 18:39:04 +0000 (14:39 -0400)]
Add $(ICONVLIB) to programs that need it.

10 years agoCreate $MH_OBJ_DIR/test/testdir if it doesn't already exist. This
David Levine [Mon, 15 Aug 2016 14:58:33 +0000 (10:58 -0400)]
Create $MH_OBJ_DIR/test/testdir if it doesn't already exist.  This
allows a test to be run standalone, now that said directory must
exist before defining $MH_TEST_DIR.

(cherry picked from commit 0f53d91688c0fab28b900ad27a1610a755dea526)

10 years agoCreate $MH_OBJ_DIR/test/testdir if it doesn't already exist. This
David Levine [Mon, 15 Aug 2016 14:58:33 +0000 (10:58 -0400)]
Create $MH_OBJ_DIR/test/testdir if it doesn't already exist.  This
allows a test to be run standalone, now that said directory must
exist before defining $MH_TEST_DIR.

10 years agoPlug a couple of (harmless) memory leaks in mhfixmsg.
David Levine [Mon, 15 Aug 2016 14:31:43 +0000 (10:31 -0400)]
Plug a couple of (harmless) memory leaks in mhfixmsg.

(cherry picked from commit 58d22c00deb7bc9c771c5293079f6f89bc28274a)

10 years agoPlug a couple of (harmless) memory leaks in mhfixmsg.
David Levine [Mon, 15 Aug 2016 14:31:43 +0000 (10:31 -0400)]
Plug a couple of (harmless) memory leaks in mhfixmsg.

10 years agoHandle base64 decoding decoding of initial response for all AUTH
David Levine [Mon, 15 Aug 2016 00:45:43 +0000 (20:45 -0400)]
Handle base64 decoding decoding of initial response for all AUTH
mechanisms the same way, based on RFC 4954 spec.  Also, don't try
to decode = or * response.

(cherry picked from commit b3ebdfc56e7a0199a60d80f54872e86969d96933)

10 years agoHandle base64 decoding decoding of initial response for all AUTH
David Levine [Mon, 15 Aug 2016 00:45:43 +0000 (20:45 -0400)]
Handle base64 decoding decoding of initial response for all AUTH
mechanisms the same way, based on RFC 4954 spec.  Also, don't try
to decode = or * response.

10 years agoNewer versions of Automake want to include the test-driver script,
Ken Hornstein [Sun, 14 Aug 2016 17:26:59 +0000 (13:26 -0400)]
Newer versions of Automake want to include the test-driver script,
so make sure we ignore it.

(cherry picked from commit bd6f799b1d98c11b50a4121c9ac763bcf1b1b3fe)

10 years agoUse isascii() with isprint(), since using isprint() on
Ken Hornstein [Sun, 14 Aug 2016 17:25:51 +0000 (13:25 -0400)]
Use isascii() with isprint(), since using isprint() on
bytes > 127 is undefined.

(cherry picked from commit 7054379384884f0975c687ce9b2cd8c20e3f2c12)

10 years agoNewer versions of Automake want to include the test-driver script,
Ken Hornstein [Sun, 14 Aug 2016 17:26:59 +0000 (13:26 -0400)]
Newer versions of Automake want to include the test-driver script,
so make sure we ignore it.