From 116b286a03fe33db3db24a56fa3518d237f5b8c2 Mon Sep 17 00:00:00 2001 From: Ralph Corderoy Date: Thu, 20 Oct 2016 23:27:37 +0100 Subject: [PATCH] Don't `else' after return. Simplify control flow. --- uip/mhstoresbr.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/uip/mhstoresbr.c b/uip/mhstoresbr.c index 57da1df4..7e91563f 100644 --- a/uip/mhstoresbr.c +++ b/uip/mhstoresbr.c @@ -1138,19 +1138,22 @@ static enum clobber_policy_t clobber_policy (const char *value) { if (value == NULL || ! strcasecmp (value, "always")) { - } else if (! strcasecmp (value, "auto")) { + return NMH_CLOBBER_ALWAYS; + } + if (! strcasecmp (value, "auto")) { return NMH_CLOBBER_AUTO; - } else if (! strcasecmp (value, "suffix")) { + } + if (! strcasecmp (value, "suffix")) { return NMH_CLOBBER_SUFFIX; - } else if (! strcasecmp (value, "ask")) { + } + if (! strcasecmp (value, "ask")) { return NMH_CLOBBER_ASK; - } else if (! strcasecmp (value, "never")) { + } + if (! strcasecmp (value, "never")) { return NMH_CLOBBER_NEVER; - } else { - adios (NULL, "invalid argument, %s, to clobber", value); } - return NMH_CLOBBER_ALWAYS; + adios (NULL, "invalid argument, %s, to clobber", value); } -- 2.56.0