From 13015c3c27462cb98027d644636ff526e10dd1d0 Mon Sep 17 00:00:00 2001 From: Ralph Corderoy Date: Tue, 1 Nov 2016 11:11:11 +0000 Subject: [PATCH] test: Remove the " # gcov" comment from check_exit calls. Now the command is passed to check_exit, that is sufficient to indicate it's for coverage uses only, and a candidate to be fleshed out into a test that checks the output. --- test/ali/test-ali | 12 ++++---- test/anno/test-anno | 28 ++++++++--------- test/burst/test-burst | 18 +++++------ test/comp/test-comp-format | 54 ++++++++++++++++----------------- test/dist/test-dist | 2 +- test/folder/test-packf | 2 +- test/folder/test-sortm | 2 +- test/format/test-fmtdump | 2 +- test/inc/test-msgchk | 2 +- test/install-mh/test-install-mh | 2 +- test/mhbuild/test-forw | 2 +- test/mhbuild/test-header-encode | 2 +- test/mhfixmsg/test-mhfixmsg | 2 +- test/mhical/test-mhical | 2 +- test/mhlist/test-mhlist | 2 +- test/mhparam/test-mhparam | 4 +-- test/mhpath/test-mhpath | 2 +- test/mhshow/test-charset | 2 +- test/mhstore/test-mhstore | 2 +- test/mkstemp/test-mkstemp | 2 +- test/new/test-basic | 2 +- test/oauth/test-inc | 2 +- test/oauth/test-mhlogin | 2 +- test/oauth/test-send | 2 +- test/post/test-post-basic | 2 +- test/prompter/test-prompter | 2 +- test/rcv/test-rcvdist | 2 +- test/rcv/test-rcvpack | 2 +- test/rcv/test-rcvstore | 2 +- test/rcv/test-rcvtty | 2 +- test/refile/test-refile | 2 +- test/repl/test-repl | 2 +- test/scan/test-scan | 2 +- test/sequences/test-flist | 2 +- test/sequences/test-mark | 2 +- test/show/test-show | 2 +- test/slocal/test-slocal | 2 +- test/whom/test-whom | 2 +- 38 files changed, 91 insertions(+), 91 deletions(-) diff --git a/test/ali/test-ali b/test/ali/test-ali index cae2b9a2..019f329a 100755 --- a/test/ali/test-ali +++ b/test/ali/test-ali @@ -19,12 +19,12 @@ fi setup_test -check_exit '-eq 1' ali - # gcov -check_exit '-eq 1' ali -noalias -alias # gcov -check_exit '-eq 1' ali -user # gcov -check_exit '-eq 1' ali -user '' # gcov -check_exit '-eq 1' ali -user 'foo bar' # gcov -check_exit '-eq 0' ali -user foo,bar # gcov +check_exit '-eq 1' ali - +check_exit '-eq 1' ali -noalias -alias +check_exit '-eq 1' ali -user +check_exit '-eq 1' ali -user '' +check_exit '-eq 1' ali -user 'foo bar' +check_exit '-eq 0' ali -user foo,bar expected=$MH_TEST_DIR/$$.expected expected_err=$MH_TEST_DIR/$$.expected_err diff --git a/test/anno/test-anno b/test/anno/test-anno index 3682e353..89204ccb 100755 --- a/test/anno/test-anno +++ b/test/anno/test-anno @@ -16,24 +16,24 @@ fi setup_test -check_exit '-eq 1' anno - # gcov -check_exit '-eq 1' anno -comp # gcov -check_exit '-eq 1' anno -comp foo -comp bar # gcov -check_exit '-eq 1' anno -text # gcov -check_exit '-eq 1' anno -text foo -text bar # gcov -check_exit '-eq 1' anno -number 0 # gcov -check_exit '-eq 1' anno -number -number # gcov -check_exit '-eq 1' anno + @ # gcov -check_exit '-eq 1' anno -draft 42 # gcov -check_exit '-eq 1' anno -draft -list /dev/null && has_mkstemps=1 || has_mkstemps=0 diff --git a/test/new/test-basic b/test/new/test-basic index 9eb4a652..5653c846 100755 --- a/test/new/test-basic +++ b/test/new/test-basic @@ -14,7 +14,7 @@ fi setup_test -check_exit '-eq 1' folder - # gcov +check_exit '-eq 1' folder - folders=$MH_TEST_DIR/Mail/.folders diff --git a/test/oauth/test-inc b/test/oauth/test-inc index 38e25f6f..de18d8f0 100755 --- a/test/oauth/test-inc +++ b/test/oauth/test-inc @@ -10,7 +10,7 @@ fi . "${srcdir}/test/oauth/common.sh" -check_exit '-eq 1' inc - # gcov +check_exit '-eq 1' inc - setup_pop diff --git a/test/oauth/test-mhlogin b/test/oauth/test-mhlogin index f55673ee..c4a7bf2d 100755 --- a/test/oauth/test-mhlogin +++ b/test/oauth/test-mhlogin @@ -10,7 +10,7 @@ fi . "${srcdir}/test/oauth/common.sh" -check_exit '-eq 1' mhlogin - # gcov +check_exit '-eq 1' mhlogin - expect_no_creds() { cat /dev/null > "${MHTMPDIR}/$$.expected-creds" diff --git a/test/oauth/test-send b/test/oauth/test-send index 7fa7bfb1..4d5a850a 100755 --- a/test/oauth/test-send +++ b/test/oauth/test-send @@ -10,7 +10,7 @@ fi . "${srcdir}/test/oauth/common.sh" -check_exit '-eq 1' send - # gcov +check_exit '-eq 1' send - test_send_only_fakehttp() { start_fakehttp diff --git a/test/post/test-post-basic b/test/post/test-post-basic index 126a6a40..39915e71 100755 --- a/test/post/test-post-basic +++ b/test/post/test-post-basic @@ -12,7 +12,7 @@ fi . "${srcdir}/test/post/test-post-common.sh" -check_exit '-eq 1' "$MH_LIBEXEC_DIR/post" - # gcov +check_exit '-eq 1' "$MH_LIBEXEC_DIR/post" - # # Basic test - Simple message, single user, single recipient. Note that diff --git a/test/prompter/test-prompter b/test/prompter/test-prompter index 2b3ad1ca..65ed8a96 100755 --- a/test/prompter/test-prompter +++ b/test/prompter/test-prompter @@ -16,7 +16,7 @@ fi setup_test -check_exit '-eq 1' prompter - # gcov +check_exit '-eq 1' prompter - expected=$MH_TEST_DIR/$$.expected expected_err=$MH_TEST_DIR/$$.expected_err diff --git a/test/rcv/test-rcvdist b/test/rcv/test-rcvdist index 8583444b..857a4edc 100755 --- a/test/rcv/test-rcvdist +++ b/test/rcv/test-rcvdist @@ -19,7 +19,7 @@ setup_test # Use proper program, likely not the first one on PATH. rcvdist="${MH_LIBEXEC_DIR}/rcvdist" -check_exit '-eq 1' $rcvdist - # gcov +check_exit '-eq 1' $rcvdist - expected=$MH_TEST_DIR/$$.expected actual=$MH_TEST_DIR/$$.actual diff --git a/test/rcv/test-rcvpack b/test/rcv/test-rcvpack index 3f306bac..a780c253 100755 --- a/test/rcv/test-rcvpack +++ b/test/rcv/test-rcvpack @@ -19,7 +19,7 @@ setup_test # Use proper program, likely not the first one on PATH. rcvpack="${MH_LIBEXEC_DIR}/rcvpack" -check_exit '-eq 1' $rcvpack - # gcov +check_exit '-eq 1' $rcvpack - expected="$MH_TEST_DIR/$$.expected" actual="$MH_TEST_DIR/$$.actual" diff --git a/test/rcv/test-rcvstore b/test/rcv/test-rcvstore index 7d88faa9..6337b893 100755 --- a/test/rcv/test-rcvstore +++ b/test/rcv/test-rcvstore @@ -19,7 +19,7 @@ setup_test # Use proper program, likely not the first one on PATH. rcvstore="${MH_LIBEXEC_DIR}/rcvstore" -check_exit '-eq 1' $rcvstore - # gcov +check_exit '-eq 1' $rcvstore - expected=$MH_TEST_DIR/$$.expected expected_err=$MH_TEST_DIR/$$.expected_err diff --git a/test/rcv/test-rcvtty b/test/rcv/test-rcvtty index 541a1866..a2cf6ca6 100755 --- a/test/rcv/test-rcvtty +++ b/test/rcv/test-rcvtty @@ -19,7 +19,7 @@ setup_test # Use proper program, likely not the first one on PATH. rcvtty="${MH_LIBEXEC_DIR}/rcvtty" -check_exit '-eq 1' $rcvtty - # gcov +check_exit '-eq 1' $rcvtty - expected="$MH_TEST_DIR/$$.expected" actual="$MH_TEST_DIR/$$.actual" diff --git a/test/refile/test-refile b/test/refile/test-refile index e3888434..58fd373f 100755 --- a/test/refile/test-refile +++ b/test/refile/test-refile @@ -16,7 +16,7 @@ fi setup_test -check_exit '-eq 1' refile - # gcov +check_exit '-eq 1' refile - expected=$MH_TEST_DIR/$$.expected actual=$MH_TEST_DIR/$$.actual diff --git a/test/repl/test-repl b/test/repl/test-repl index 7de80246..5d0d7de4 100755 --- a/test/repl/test-repl +++ b/test/repl/test-repl @@ -19,7 +19,7 @@ fi setup_test -check_exit '-eq 1' repl - # gcov +check_exit '-eq 1' repl - expected=$MH_TEST_DIR/$$.expected actual=$MH_TEST_DIR/Mail/draft diff --git a/test/scan/test-scan b/test/scan/test-scan index 070e9faf..dc0e2250 100755 --- a/test/scan/test-scan +++ b/test/scan/test-scan @@ -14,7 +14,7 @@ fi setup_test -check_exit '-eq 1' scan - # gcov +check_exit '-eq 1' scan - expected="$MH_TEST_DIR/$$.expected" actual="$MH_TEST_DIR/$$.actual" diff --git a/test/sequences/test-flist b/test/sequences/test-flist index 037272d7..52d16c10 100755 --- a/test/sequences/test-flist +++ b/test/sequences/test-flist @@ -16,7 +16,7 @@ fi setup_test -check_exit '-eq 1' flist - # gcov +check_exit '-eq 1' flist - run_test 'mark 1 3 5 7 9 +inbox -sequence odd' '' run_test 'mark -s odd -list' 'odd: 1 3 5 7 9' diff --git a/test/sequences/test-mark b/test/sequences/test-mark index 83199239..bce141a5 100755 --- a/test/sequences/test-mark +++ b/test/sequences/test-mark @@ -16,7 +16,7 @@ fi setup_test -check_exit '-eq 1' mark - # gcov +check_exit '-eq 1' mark - # Test sequence creation. run_test 'mark 1 3 5 7 +inbox -sequence odd' '' diff --git a/test/show/test-show b/test/show/test-show index 07050fa3..64859d21 100755 --- a/test/show/test-show +++ b/test/show/test-show @@ -9,7 +9,7 @@ fi setup_test -check_exit '-eq 1' show - # gcov +check_exit '-eq 1' show - expected=$MH_TEST_DIR/$$.expected actual=$MH_TEST_DIR/$$.actual diff --git a/test/slocal/test-slocal b/test/slocal/test-slocal index 6924d7bc..1213117b 100755 --- a/test/slocal/test-slocal +++ b/test/slocal/test-slocal @@ -19,7 +19,7 @@ setup_test # Use proper program, maybe not the first one on PATH. slocal="$MH_LIBEXEC_DIR"/slocal -check_exit '-eq 1' $slocal - # gcov +check_exit '-eq 1' $slocal - expected="$MH_TEST_DIR"/$$.expected actual="$MH_TEST_DIR"/$$.actual diff --git a/test/whom/test-whom b/test/whom/test-whom index 537fc2dc..e8341a54 100755 --- a/test/whom/test-whom +++ b/test/whom/test-whom @@ -19,7 +19,7 @@ fi setup_test -check_exit '-eq 1' whom - # gcov +check_exit '-eq 1' whom - expected=$MH_TEST_DIR/$$.expected actual=$MH_TEST_DIR/$$.actual -- 2.56.0