From 22b4921abcdbdf12008c925df78f36357c4925c4 Mon Sep 17 00:00:00 2001 From: David Levine Date: Thu, 1 Nov 2018 19:44:32 -0400 Subject: [PATCH] Increased sizes of a couple of buffers. gcc 8 noticed that snprintf could have overrun them. It might be better to reduce the sizes of buffers used for display names, etc. Or ever better, use dynamically sized buffers. --- sbr/mts.c | 2 +- uip/replsbr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sbr/mts.c b/sbr/mts.c index 13c3a08a..452dc735 100644 --- a/sbr/mts.c +++ b/sbr/mts.c @@ -54,7 +54,7 @@ char *spoollocking = DEFAULT_LOCKING; /* Cache the username, fullname, and mailbox of the user */ static char username[BUFSIZ]; static char fullname[BUFSIZ]; -static char localmbox[BUFSIZ]; +static char localmbox[2*BUFSIZ+3]; /* * MTS specific variables diff --git a/uip/replsbr.c b/uip/replsbr.c index 55bcd6ce..e3c88949 100644 --- a/uip/replsbr.c +++ b/uip/replsbr.c @@ -294,7 +294,7 @@ static char * replformataddr (char *orig, char *str) { int len; - char baddr[BUFSIZ], error[BUFSIZ]; + char baddr[BUFSIZ+6], error[BUFSIZ]; bool isgroup; char *dst; char *cp; -- 2.56.0