From 2e45544e082577402083dec7e23089d74ac7d89f Mon Sep 17 00:00:00 2001 From: Ken Hornstein Date: Sun, 23 Feb 2014 21:29:52 -0500 Subject: [PATCH] Fix up error reporting for the hook code. --- sbr/ext_hook.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/sbr/ext_hook.c b/sbr/ext_hook.c index 26f2c1c0..7b94e57a 100644 --- a/sbr/ext_hook.c +++ b/sbr/ext_hook.c @@ -37,6 +37,7 @@ ext_hook(char *hook_name, char *message_file_name_1, char *message_file_name_2) vec[vecp++] = message_file_name_2; vec[vecp++] = NULL; execvp(program, vec); + advise(program, "Unable to execute"); _exit(-1); /* NOTREACHED */ @@ -47,11 +48,14 @@ ext_hook(char *hook_name, char *message_file_name_1, char *message_file_name_2) if (status != OK) { if (did_message == 0) { - if ((hook = context_find("msg-hook")) != (char *)0) - advise(NULL, hook); - else - advise(NULL, "external hook (%s) did not work properly.", hook); - + char *msghook; + if ((msghook = context_find("msg-hook")) != (char *)0) + advise(NULL, msghook); + else { + char errbuf[BUFSIZ]; + snprintf(errbuf, sizeof(errbuf), "external hook \"%s\"", hook); + pidstatus(status, stderr, errbuf); + } did_message = 1; } -- 2.56.0