From 984c278593ba8b52cc30caf8d8dfaf184f3c5b4c Mon Sep 17 00:00:00 2001 From: Ken Hornstein Date: Thu, 22 Sep 2016 19:12:12 -0400 Subject: [PATCH] Add error reporting for one case, and move around the return code in the SASL callback a bit. --- uip/popsbr.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/uip/popsbr.c b/uip/popsbr.c index 70d71044..9e394287 100644 --- a/uip/popsbr.c +++ b/uip/popsbr.c @@ -384,8 +384,10 @@ pop_sasl_callback(enum sasl_message_type mtype, unsigned const char *indata, } else { rc = decodeBase64(line + 2, (const char **) outdata, &len, 0, NULL); *outdatalen = len; - if (rc != OK) + if (rc != OK) { + netsec_err(errstr, "Unable to decode base64 response"); return NOTOK; + } } break; @@ -411,8 +413,6 @@ pop_sasl_callback(enum sasl_message_type mtype, unsigned const char *indata, if (netsec_flush(nsc, errstr) != OK) return NOTOK; - - return OK; break; /* @@ -447,7 +447,8 @@ pop_sasl_callback(enum sasl_message_type mtype, unsigned const char *indata, return NOTOK; break; } -return OK; + + return OK; } /* -- 2.56.0