From d247f1cf67f3e579ccddfa986c603dd91880cbe7 Mon Sep 17 00:00:00 2001 From: Ralph Corderoy Date: Sun, 10 Sep 2017 15:11:18 +0100 Subject: [PATCH] find_cache(): Remove test that's always false. The if-statement's condition is a conjunctive that tests `!writing' and then, only if that's true, calls find_cache_aux() and tests `writing' in determining the first argument; that must be false. Bug pre-dates git history. --- uip/mhcachesbr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uip/mhcachesbr.c b/uip/mhcachesbr.c index 9b410e22..b740e231 100644 --- a/uip/mhcachesbr.c +++ b/uip/mhcachesbr.c @@ -181,7 +181,7 @@ find_cache (CT ct, int policy, int *writing, char *id, case CACHE_PUBLIC: if (cache_private && !writing - && find_cache_aux (writing ? 2 : 0, cache_private, id, + && find_cache_aux (0, cache_private, id, buffer, buflen) == OK) { if (access (buffer, R_OK) != NOTOK) { got_private: -- 2.56.0