From d3bc59068db8bcc73c26ca70c5fdfb88eb1dd9d3 Mon Sep 17 00:00:00 2001
From: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun, 16 Apr 2017 23:36:07 +0100
Subject: [PATCH] uip/aliasbr.c: Add FIXME to prove test of add()'s return
 value.

add() always returns true so perhaps some other test is intended
instead.
---
 uip/aliasbr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/uip/aliasbr.c b/uip/aliasbr.c
index 015f48a4..0c1c6ba8 100644
--- a/uip/aliasbr.c
+++ b/uip/aliasbr.c
@@ -132,6 +132,8 @@ akval (struct aka *ak, char *s)
 		if (mp	&&  mp->m_ingrp) {
 		    char *gname = add (mp->m_gname, NULL);
 
+                    /* FIXME: gname must be true;  add() never returns NULL.
+		     * Is some other test required? */
 		    if (gname  &&  aleq (name, ak->ak_name)) {
 			/* Will leak cp. */
 			cp = concat (gname, akresult (ak), NULL);
-- 
2.56.0