Chase Douglas [Wed, 17 Nov 2010 15:42:38 +0000 (10:42 -0500)]
Zero out entire mask when selecting for different events
Signed-off-by: Chase Douglas <chase.douglas@canonical.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Chase Douglas [Thu, 1 Jul 2010 22:36:42 +0000 (18:36 -0400)]
xinput: Split XI2 valuators and print index of events
XI2 events support bitmask selected valuators. When printing masked
events, we need to also print the index of the valuator value. This
change prints each valuator on its own line, prefixed by its index
Signed-off-by: Chase Douglas <chase.douglas@canonical.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 9 Jun 2010 05:52:31 +0000 (15:52 +1000)]
list: only check the last bit in the device mode.
This works around a bug in X servers 1.7.x, 1.8.0 and 1.8.1 where the device
mode could sometimes be binary OR'd with the OutOfProximity flag. The result
was a value of 0b10 for relative and 0b11 for Absolute, both of which were
interpreted as relative by this code.
Affected is only the XIQueryDevice call, not the XListInputDevices call.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
A 32bit value must be dereferenced to correctly zero-extend an Atom
from XIGetProperty. On 64bit systems, Atom is 64bits, so the final
Atom in a list will read garbage in the upper half of the Atom.
Will Thompson [Thu, 1 Apr 2010 14:35:34 +0000 (15:35 +0100)]
Warn and fail if a device name is ambiguous.
The XI1 path bails out if the user specifies a device by name and there
is more than one device, but the XI2 path previously just silently chose
the first one. This patch makes it fail outright.
Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Gaetan Nadon [Wed, 28 Oct 2009 18:09:08 +0000 (14:09 -0400)]
INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206
Add missing INSTALL file. Use standard GNU file on building tarball
README may have been updated
Remove AUTHORS file as it is empty and no content available yet.
Remove NEWS file as it is empty and no content available yet.
Gaetan Nadon [Tue, 27 Oct 2009 19:07:25 +0000 (15:07 -0400)]
Deploy the new XORG_DEFAULT_OPTIONS #24242
This macro aggregate a number of existing macros that sets commmon
X.Org components configuration options. It shields the configuration file from
future changes.
Gaetan Nadon [Thu, 22 Oct 2009 16:34:15 +0000 (12:34 -0400)]
.gitignore: use common defaults with custom section # 24239
Using common defaults will reduce errors and maintenance.
Only the very small or inexistent custom section need periodic maintenance
when the structure of the component changes. Do not edit defaults.
On Wed, 2009-10-21 at 13:36 +1000, Peter Hutterer wrote:
> On Tue, Oct 20, 2009 at 08:23:55PM -0700, Jeremy Huddleston wrote:
> > I noticed an INSTALL file in xlsclients and libXvMC today, and it
> > was quite annoying to work around since 'autoreconf -fvi' replaces
> > it and git wants to commit it. Should these files even be in git?
> > Can I nuke them for the betterment of humanity and since they get
> > created by autoreconf anyways?
>
> See https://bugs.freedesktop.org/show_bug.cgi?id=24206
As an interim measure, replace AM_INIT_AUTOMAKE([dist-bzip2]) with
AM_INIT_AUTOMAKE([foreign dist-bzip2]). This will prevent the generation
of the INSTALL file. It is also part of the 24206 solution.
Signed-off-by: Jeremy Huddleston <jeremyhu@freedesktop.org>
Peter Hutterer [Fri, 9 Oct 2009 05:28:34 +0000 (15:28 +1000)]
Clean up --version, don't require a DISPLAY and display the server version too.
version.c was removed, seemed a bit excessive for the 20 lines of code.
--version is integrated separate from the other commands now, checked before
opening the display. xinput now prints its own version in all cases, even if
the display is unavailable. If the display is available, it prints the
server version too. Example output:
$> xinput --version
xinput version 1.4.99.3
XI version on server: 2.0
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 9 Oct 2009 05:07:30 +0000 (15:07 +1000)]
man: clean up the man page.
Several changes to the man page to tidy it up a bit:
- RCS tag removed
- synopsis shortened, OPTIONS section added instead
- "xinput" dropped before the option descriptions, options in manpage
prefixed with '--'.
- device_name replaced with just device, since it may be a deviceid.
- Removed references to XI man page calls that some options use, it really
doesn't matter to users what the underlying Xlib call is.
- mark set-int-prop and set-float-prop as deprecated in the man page.
- add --test_xi2 flag
- Added a few more authors.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Alan Coopersmith <alan.coopersmith@sun.com>
Thomas Jaeger [Wed, 7 Oct 2009 17:05:15 +0000 (13:05 -0400)]
Rework 'xinput list' code
* Drop the questionable --loop option
* Add a --long option (opposite of --short)
* Make --short the default if no device argument is given
* XI2: Make it possible to query a single device
Signed-off-by: Thomas Jaeger <ThJaeger@gmail.com>
squashed in a man page update for --short and --long.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 24 Jun 2009 00:30:45 +0000 (10:30 +1000)]
test_xi2: don't map the window before selecting for events.
Mapping the window before selecting for XI2 events leaves some events out
(e.g. enter events if the pointer is already in the area where the window is
being mapped).
Reported-by: Thomas Jaeger Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Thu, 7 May 2009 04:13:45 +0000 (14:13 +1000)]
Get the XIDeviceInfo instead of just the id.
This way we leak the XIDeviceInfo array, but then again it doesn't matter
since we exit after the command anyway.
And with the XIDeviceInfo around, we can actually print the name and
whatnot.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 1 May 2009 01:22:53 +0000 (11:22 +1000)]
Create the float property if it doesn't exist.
If we don't have the float property we won't be able to use float properties
for device configuration since the drivers may not understand it.
We might still want to apply properties for client settings though.
Reported-by: Simon Thum <simon.thum@gmx.de> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
There's no reason to require the user to know the difference between
set-int-prop, set-float-prop and set-atom-prop, and to know the required
format for each integer property, since we can just ask
XGetDeviceProperty.
Signed-off-by: Julien Cristau <jcristau@debian.org> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
projects / xorg-xinput / log