fix some failing tests

diff --git a/fa-encode b/fa-encode
index 1656353..9388f07 100755 (executable)
--- a/fa-encode
+++ b/fa-encode
@@ -114,6 +114,7 @@ sub main {
             );
         -e $fn && die("cowardly refusing to clobber $fn");
         my @pictures = ('--picture', quote('3|image/jpeg|||cover.front.jpeg')); # TODO optional
             );
         -e $fn && die("cowardly refusing to clobber $fn");
         my @pictures = ('--picture', quote('3|image/jpeg|||cover.front.jpeg')); # TODO optional

+        @pictures = ();         # XXX

         my $tracknum_s = two_digits($tracknum);
         say(join(' ',
                  'flac -o',
         my $tracknum_s = two_digits($tracknum);
         say(join(' ',
                  'flac -o',

diff --git a/t/disc_tags.t b/t/disc_tags.t
index 0d12a0a..780c9e5 100644 (file)
--- a/t/disc_tags.t
+++ b/t/disc_tags.t
@@ -20,6 +20,7 @@ eq_or_diff
      'The Spectre Within',
      '1985',
      [],
      'The Spectre Within',
      '1985',
      [],

+     undef,

     ],
     'single disc';
 
     ],
     'single disc';
 


@@ -35,6 +36,7 @@ eq_or_diff
      '101',
      '1989-03-14',
      [2],
      '101',
      '1989-03-14',
      [2],

+     undef,

     ],
     'second disc';
 
     ],
     'second disc';
 


@@ -50,6 +52,7 @@ eq_or_diff
      'Close',
      undef,
      [],
      'Close',
      undef,
      [],

+     undef,

     ],
     'extraneous DISCNUMBER tag with DISCTOTAL=1 ignored';
 
     ],
     'extraneous DISCNUMBER tag with DISCTOTAL=1 ignored';
 

diff --git a/t/mp3cd/plan.t b/t/mp3cd/plan.t
index 4e1343d..a11d2bf 100644 (file)
--- a/t/mp3cd/plan.t
+++ b/t/mp3cd/plan.t
@@ -41,6 +41,7 @@ eq_or_diff
              discnumber => [],
              tracknumber => 1,
              title => 'Tarot Woman',
              discnumber => [],
              tracknumber => 1,
              title => 'Tarot Woman',

+             version => undef,

          }
      },
      {
          }
      },
      {


@@ -54,6 +55,7 @@ eq_or_diff
              discnumber => [],
              tracknumber => 2,
              title => 'Run With the Wolf',
              discnumber => [],
              tracknumber => 2,
              title => 'Run With the Wolf',

+             version => undef,

          }
      },
     ],
          }
      },
     ],


@@ -72,6 +74,7 @@ eq_or_diff
              discnumber => [],
              tracknumber => 1,
              title => 'faket',
              discnumber => [],
              tracknumber => 1,
              title => 'faket',

+             version => undef,

          }
      }
     ],
          }
      }
     ],


@@ -101,6 +104,7 @@ eq_or_diff
              discnumber => [],
              tracknumber => 1,
              title => 'faket',
              discnumber => [],
              tracknumber => 1,
              title => 'faket',

+             version => undef,

          }
      }
     ],
          }
      }
     ],

diff --git a/tags.pl b/tags.pl
index 76ac441..3fc4f84 100644 (file)
--- a/tags.pl
+++ b/tags.pl
@@ -85,7 +85,7 @@ our @EXPORT_OK = qw[
 ];
 
 sub two_digits {
 ];
 
 sub two_digits {

-    my $n = shift;
+    my $n = shift || 0;

     my  $s = sprintf('%02d', $n);
     if (length($s) != 2) {
         die("$n won't fit into two digits")
     my  $s = sprintf('%02d', $n);
     if (length($s) != 2) {
         die("$n won't fit into two digits")