Add error reporting for one case, and move around the return code

in the SASL callback a bit.

diff --git a/uip/popsbr.c b/uip/popsbr.c
index 70d710446a40deca875817fa080edd5b2eed7722..9e394287501dbc9dd560b243cf25a60cbb35f3b9 100644 (file)
--- a/uip/popsbr.c
+++ b/uip/popsbr.c
@@ -384,8 +384,10 @@ pop_sasl_callback(enum sasl_message_type mtype, unsigned const char *indata,
        } else {
            rc = decodeBase64(line + 2, (const char **) outdata, &len, 0, NULL);
            *outdatalen = len;
-           if (rc != OK)
+           if (rc != OK) {
+               netsec_err(errstr, "Unable to decode base64 response");
                return NOTOK;
+           }
        }
        break;
 
@@ -411,8 +413,6 @@ pop_sasl_callback(enum sasl_message_type mtype, unsigned const char *indata,
 
        if (netsec_flush(nsc, errstr) != OK)
            return NOTOK;
-
-       return OK;
        break;
 
     /*
@@ -447,7 +447,8 @@ pop_sasl_callback(enum sasl_message_type mtype, unsigned const char *indata,
            return NOTOK;
        break;
     }
-return OK;
+
+    return OK;
 }
 
 /*