]> diplodocus.org Git - nmh/log
nmh
13 years agoUpdate manpages to use .TP for tagged paragraphs (part I).
Lyndon Nerenberg [Fri, 1 Feb 2013 08:20:44 +0000 (00:20 -0800)]
Update manpages to use .TP for tagged paragraphs (part I).

This replaces .fc/.nf and friends with the man(7) .TP macro.

This commit covers about half of the man pages.  The rest will
follow in a couple of days.

13 years agoUpdate the manpage template documentation.
Lyndon Nerenberg [Fri, 1 Feb 2013 05:28:51 +0000 (21:28 -0800)]
Update the manpage template documentation.

Update the section ordering to follow the UNIX order.  This
pulls nmh-specific sections into the body of the manpage, and
pushes FILES, SEE ALSO, and BUGS to the end.

Clarifies a few other minor points.

13 years agoMore probing of test-ali on Solaris: exit before the
David Levine [Fri, 1 Feb 2013 04:32:26 +0000 (22:32 -0600)]
More probing of test-ali on Solaris:  exit before the
setup_test call, which has the folder invocation.

13 years agoOK, test-pick should be good on Solaris now.
David Levine [Fri, 1 Feb 2013 04:30:36 +0000 (22:30 -0600)]
OK, test-pick should be good on Solaris now.

13 years agoAdded exit to test-ali, temporarily, to isolate failure on
David Levine [Fri, 1 Feb 2013 03:27:46 +0000 (21:27 -0600)]
Added exit to test-ali, temporarily, to isolate failure on
Solaris.

13 years agoMore homing in on the test-pick warning. Also, removed
David Levine [Fri, 1 Feb 2013 03:24:53 +0000 (21:24 -0600)]
More homing in on the test-pick warning.  Also, removed
warning to user that the tty test is being skipped, it's
not that important.

13 years agoRemoved an used sed invocation from test-mhmail. I don't
David Levine [Fri, 1 Feb 2013 02:10:59 +0000 (20:10 -0600)]
Removed an used sed invocation from test-mhmail.  I don't
know if it was causing the warnings on Solaris, we'll see.

13 years agoFix some warnings for Solaris.
Ken Hornstein [Fri, 1 Feb 2013 02:04:43 +0000 (21:04 -0500)]
Fix some warnings for Solaris.

13 years agoit looks like the write to /dev/tty is causing the warning from
David Levine [Fri, 1 Feb 2013 02:04:50 +0000 (20:04 -0600)]
it looks like the write to /dev/tty is causing the warning from
test-pick on Solaris, here's an attempt to squelch that.

13 years agoRemoved sizes from mhlist output. Apparently tar files are
David Levine [Fri, 1 Feb 2013 01:44:47 +0000 (19:44 -0600)]
Removed sizes from mhlist output.  Apparently tar files are
so much smaller on Solaris that they cause the check of its
output to break.  The test also compares the contents of
the tar file, so it's still adequate.

13 years agoRedirected stderr to /dev/null in the test for presence of
David Levine [Fri, 1 Feb 2013 01:43:09 +0000 (19:43 -0600)]
Redirected stderr to /dev/null in the test for presence of
/dev/tty.  Solaris warns that it can't create the device.
This may not fix it, but it should help isolate which part of
the test is causing the warning.

13 years agoSet the locale for one of the "pick" invocations to UTF-8, so we can decode
Ken Hornstein [Fri, 1 Feb 2013 01:01:27 +0000 (20:01 -0500)]
Set the locale for one of the "pick" invocations to UTF-8, so we can decode
the UTF-8 header correctly in the test.

13 years agoUse cmp(1) to compare acheieved and expected test results.
Lyndon Nerenberg [Thu, 31 Jan 2013 11:56:55 +0000 (03:56 -0800)]
Use cmp(1) to compare acheieved and expected test results.

'diff -c' on Solaris 11 generate a spurious 'No differences encountered'
message (on stdout, no less!) when the compared files are identical. This
changes the test logic to compare with 'cmp -s', and then perform a
'diff -c' if the results don't match expectations.

13 years agoWrap 'pick -subject foobar 13' test with set +e/-e.
Lyndon Nerenberg [Thu, 31 Jan 2013 09:44:03 +0000 (01:44 -0800)]
Wrap 'pick -subject foobar 13' test with set +e/-e.

The command was failing silently on FreeBSD, leading to
premature script termination.

13 years agoChange the MD5FMT macro in configure.ac to not emit filename.
Lyndon Nerenberg [Thu, 31 Jan 2013 07:55:26 +0000 (23:55 -0800)]
Change the MD5FMT macro in configure.ac to not emit filename.

13 years agoHow hard can it be to write a portable shell function that does nothing?
Lyndon Nerenberg [Thu, 31 Jan 2013 07:07:17 +0000 (23:07 -0800)]
How hard can it be to write a portable shell function that does nothing?

Pretty hard, apparently :-P

13 years agoHush progress indicator during tests when stdout is not a tty.
Lyndon Nerenberg [Thu, 31 Jan 2013 05:45:16 +0000 (21:45 -0800)]
Hush progress indicator during tests when stdout is not a tty.

This eliminates 100 lines of logfile spam during buildbot runs.

13 years agoMerge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh into nmh
Lyndon Nerenberg [Thu, 31 Jan 2013 03:58:16 +0000 (19:58 -0800)]
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh into nmh

13 years agoIPPROTO_TCP requires <netinet/in.h>
Lyndon Nerenberg [Thu, 31 Jan 2013 03:57:22 +0000 (19:57 -0800)]
IPPROTO_TCP requires <netinet/in.h>

At least on BSD it does.

13 years agoMore changes to use argsplit() for helper programs.
Ken Hornstein [Wed, 30 Jan 2013 20:47:32 +0000 (15:47 -0500)]
More changes to use argsplit() for helper programs.

13 years agoSwitch the editor invocation over to use argsplit().
Ken Hornstein [Tue, 29 Jan 2013 20:58:34 +0000 (15:58 -0500)]
Switch the editor invocation over to use argsplit().

13 years agoThe start of the use of argsplit() to process command strings.
Ken Hornstein [Tue, 29 Jan 2013 20:30:36 +0000 (15:30 -0500)]
The start of the use of argsplit() to process command strings.

13 years agoChanged m_getfld() buffer size to 4096 from 8192, to benefit
David Levine [Tue, 29 Jan 2013 03:38:39 +0000 (21:38 -0600)]
Changed m_getfld() buffer size to 4096 from 8192, to benefit
scan(1).  We could consider using a larger buffer size when
readying message bodies.  But I expect any benefit would be
overshadowed by the way parse_mime() currently reads MIME
messages:  it reopens the file for each part.

13 years agoAdded m_getfld_track_filepos() for callers to indicate that they
David Levine [Tue, 29 Jan 2013 03:20:22 +0000 (21:20 -0600)]
Added m_getfld_track_filepos() for callers to indicate that they
may interleave fseek*/ftell* calls with m_getfld() calls.  This
eliminates the need for m_getfld() to call fseek() when called
by inc(1) and scan(1).

13 years agoAdded scan_reset_m_getfld_state(), for msh only. It needs to
David Levine [Tue, 29 Jan 2013 01:12:17 +0000 (19:12 -0600)]
Added scan_reset_m_getfld_state(), for msh only.  It needs to
call that so that it can support more than one operation on its
mailbox.

13 years agoMerge branch 'm_getfld'
David Levine [Sun, 27 Jan 2013 16:37:54 +0000 (10:37 -0600)]
Merge branch 'm_getfld'

13 years agoIn the sortm warning message, say "file modification time"
David Levine [Sun, 27 Jan 2013 16:11:10 +0000 (10:11 -0600)]
In the sortm warning message, say "file modification time"
instead of "file mtime", per Paul F.'s suggestion.

13 years agoChanged sortm warning message from an amonish() to and advise(),
David Levine [Sun, 27 Jan 2013 15:34:58 +0000 (09:34 -0600)]
Changed sortm warning message from an amonish() to and advise(),
and included the remedy of using the file mtime, per suggestions
of Norm and Ralph.

13 years agoFixed a couple of calls to m_getfld(): they were in while loops
David Levine [Sun, 27 Jan 2013 14:37:31 +0000 (08:37 -0600)]
Fixed a couple of calls to m_getfld():  they were in while loops
and the loop bodies were missing brackets.

13 years agoDeprecated msh(1).
David Levine [Sat, 26 Jan 2013 15:42:25 +0000 (09:42 -0600)]
Deprecated msh(1).

13 years agoIn build_nmh's output from the test suite: retain
David Levine [Sat, 26 Jan 2013 15:00:48 +0000 (09:00 -0600)]
In build_nmh's output from the test suite:  retain
colorization and list any test failures.

13 years agoEnabled colorized test output (PASS/FAIL/summary) by default
David Levine [Sat, 26 Jan 2013 14:52:50 +0000 (08:52 -0600)]
Enabled colorized test output (PASS/FAIL/summary) by default
via "color-tests" automake option.  To disable at runtime,
either set your AM_COLOR_TESTS environment variable to "no",
or provide that on the make check command line.

13 years agoReworked the new documentation in m_getfld.c.
David Levine [Sat, 26 Jan 2013 04:21:53 +0000 (22:21 -0600)]
Reworked the new documentation in m_getfld.c.

13 years agoHandle the case in the test suite where wcwidth() can return different
Ken Hornstein [Sat, 26 Jan 2013 03:22:46 +0000 (22:22 -0500)]
Handle the case in the test suite where wcwidth() can return different
values for combining Unicode codepoints on different operating systems.

13 years agoFix the format engine so it properly keeps track of multibyte characters
Ken Hornstein [Thu, 24 Jan 2013 21:05:36 +0000 (16:05 -0500)]
Fix the format engine so it properly keeps track of multibyte characters
and column positions when processing components and other functions.

When working on this code I realized we have nothing that checks to make
sure right justification of format function output works properly, so a
test for right justification is also included.

13 years agoAdded functions for inc, msh, rcvtty, and scan to access
David Levine [Thu, 24 Jan 2013 02:24:21 +0000 (20:24 -0600)]
Added functions for inc, msh, rcvtty, and scan to access
scansbr's gstate instance so it can be hidden, except for
msh's uses of m_getfld().

13 years agoFix a bug leading to message corruption with inc when incorporation more
Ken Hornstein [Mon, 21 Jan 2013 15:32:37 +0000 (10:32 -0500)]
Fix a bug leading to message corruption with inc when incorporation more
than one message at a time.

When I reworked the scan() code to remove the use of stdio internals,
two code paths were created.  The inc code path consumed another buffer
from the nxtbuf list for processing the message body.  At the end of
scan() there was code to push back all of the consumed buffers to the
nxtbuf list.  The extra buffer consumed in the inc code path wasn't
being pushed back, and as a result the nxtbuf list would end up with
duplicate pointers in it.  This would result in two components sharing
the same text buffer, which caused the message corruption.

When I looked at this closer, I realized that there was no reason to
push those buffers back to the list; nxtbuf gets reset to compbuffers
at the start of every call to scan(), and nxtbuf isn't used after the
buffers are pushed back.  Some researched revealed that this was the
same back in the original MH code.  I decided it was simplest to simply
delete the buffer recycling code.
(cherry picked from commit 22d2acba60374851c291260ff6aa716e9bf44a6d)

13 years agoBrought over changes to test-pop from master to m_getfld branch.
David Levine [Thu, 24 Jan 2013 01:42:56 +0000 (19:42 -0600)]
Brought over changes to test-pop from master to m_getfld branch.

13 years agoAdded scan and inc from mbox with multiple messages.
David Levine [Sun, 20 Jan 2013 14:38:18 +0000 (08:38 -0600)]
Added scan and inc from mbox with multiple messages.
(cherry picked from commit c4c53777458bfcfd288d45b7708e52eb47c56405)

13 years agoAdded test-msg-buffer-boundaries.
David Levine [Fri, 18 Jan 2013 02:58:25 +0000 (20:58 -0600)]
Added test-msg-buffer-boundaries.
(cherry picked from commit dbd0fa0a56a222bd118fea627eba53e5d9811d01)

13 years agoBrought over changes to test-pop from m_getfld branch.
David Levine [Thu, 24 Jan 2013 01:20:40 +0000 (19:20 -0600)]
Brought over changes to test-pop from m_getfld branch.

13 years agoChanged m_getfld() to automatically allocate a new state
David Levine [Wed, 23 Jan 2013 03:02:49 +0000 (21:02 -0600)]
Changed m_getfld() to automatically allocate a new state
instance as needed.  Callers no longer use
m_getfld_state_init().

13 years agoRemoved unnecessary m_getfld_state_destroy() from scan.c.
David Levine [Tue, 22 Jan 2013 23:08:21 +0000 (17:08 -0600)]
Removed unnecessary m_getfld_state_destroy() from scan.c.

13 years agoReworked enter_getfld() and Peek().
David Levine [Tue, 22 Jan 2013 23:07:47 +0000 (17:07 -0600)]
Reworked enter_getfld() and Peek().

13 years agoFix a bug leading to message corruption with inc when incorporation more
Ken Hornstein [Mon, 21 Jan 2013 15:32:37 +0000 (10:32 -0500)]
Fix a bug leading to message corruption with inc when incorporation more
than one message at a time.

When I reworked the scan() code to remove the use of stdio internals,
two code paths were created.  The inc code path consumed another buffer
from the nxtbuf list for processing the message body.  At the end of
scan() there was code to push back all of the consumed buffers to the
nxtbuf list.  The extra buffer consumed in the inc code path wasn't
being pushed back, and as a result the nxtbuf list would end up with
duplicate pointers in it.  This would result in two components sharing
the same text buffer, which caused the message corruption.

When I looked at this closer, I realized that there was no reason to
push those buffers back to the list; nxtbuf gets reset to compbuffers
at the start of every call to scan(), and nxtbuf isn't used after the
buffers are pushed back.  Some researched revealed that this was the
same back in the original MH code.  I decided it was simplest to simply
delete the buffer recycling code.

13 years agoPlugged small memory leak in m_unknown().
David Levine [Mon, 21 Jan 2013 14:42:20 +0000 (08:42 -0600)]
Plugged small memory leak in m_unknown().

13 years agoReplaced hard-coded value with MAX_DELIMITER_SIZE in m_getfld.c.
David Levine [Mon, 21 Jan 2013 04:22:17 +0000 (22:22 -0600)]
Replaced hard-coded value with MAX_DELIMITER_SIZE in m_getfld.c.

13 years agoRemoved the static m_getfld() state instance and replaced
David Levine [Mon, 21 Jan 2013 03:27:54 +0000 (21:27 -0600)]
Removed the static m_getfld() state instance and replaced
with functions for callers to create and destroy their own
instances.  This also allows inc, msh, and pick to call
m_getfld() with an initial file stream position other than 0.

There is now a global state instance so that scan can call
m_unknown() on maildrop files.  It'd be nice to get rid of
that.

13 years agoFix memory leak in arglist code
Ken Hornstein [Mon, 21 Jan 2013 03:23:58 +0000 (22:23 -0500)]
Fix memory leak in arglist code

13 years agoAdded scan and inc from mbox with multiple messages.
David Levine [Sun, 20 Jan 2013 14:38:18 +0000 (08:38 -0600)]
Added scan and inc from mbox with multiple messages.

13 years agoUpdated test-inc-scanout on master to match version of
David Levine [Sun, 20 Jan 2013 13:49:58 +0000 (07:49 -0600)]
Updated test-inc-scanout on master to match version of
m_getfld branch.

13 years agoAdded a FILE * to the m_getfld_state struct so that most
David Levine [Sat, 19 Jan 2013 14:33:38 +0000 (08:33 -0600)]
Added a FILE * to the m_getfld_state struct so that most
functions don't need to pass it explicitly.  Note that
m_getfld() must still be passed the FILE * because some
callers, e.g., those in mhparse.c, reopen their input file
and therefore pass different FILE *'s for the same input.

13 years agoMoved all file static data in m_getfld.c into the
David Levine [Sat, 19 Jan 2013 14:00:03 +0000 (08:00 -0600)]
Moved all file static data in m_getfld.c into the
m_getfld_state struct.  Changed MSG_INPUT_SIZE from
hard-coded number to BUFSIZ.

13 years agoAdded check of -pack to test-pop.
David Levine [Sat, 19 Jan 2013 12:54:10 +0000 (06:54 -0600)]
Added check of -pack to test-pop.

13 years agoFixed test-header to work on Cygwin, which has a BUFSIZ of
David Levine [Sat, 19 Jan 2013 01:19:00 +0000 (19:19 -0600)]
Fixed test-header to work on Cygwin, which has a BUFSIZ of
only 1024.  That caused an error message to be truncated.

13 years agoBeginning of implementation of new argsplit() function to handle arguments
Ken Hornstein [Fri, 18 Jan 2013 21:03:26 +0000 (16:03 -0500)]
Beginning of implementation of new argsplit() function to handle arguments
to profile-defined commands.

13 years agoRemoved all traces of m_getfld() FLDEOF and BODYEOF states.
David Levine [Fri, 18 Jan 2013 03:58:50 +0000 (21:58 -0600)]
Removed all traces of m_getfld() FLDEOF and BODYEOF states.
They were never set by m_getfld(), so all caller code that
supported them was completely unexercised.

13 years agoMinimized message files reads in m_getfld() when the caller
David Levine [Fri, 18 Jan 2013 03:46:54 +0000 (21:46 -0600)]
Minimized message files reads in m_getfld() when the caller
interleaves calls to fseek().  Added check of handling of
long header field name without a colon to test-header.

13 years agoAdded test-msg-buffer-boundaries.
David Levine [Fri, 18 Jan 2013 02:58:25 +0000 (20:58 -0600)]
Added test-msg-buffer-boundaries.

13 years agoMore cleanup of m_getfld(), changed some variable names.
David Levine [Thu, 17 Jan 2013 04:02:12 +0000 (22:02 -0600)]
More cleanup of m_getfld(), changed some variable names.

13 years agoAdded check of header field body with more than 511
David Levine [Thu, 17 Jan 2013 03:48:11 +0000 (21:48 -0600)]
Added check of header field body with more than 511
characters to test-inc-scanout.  Also changed a couple of
test message files to be generated on the fly.

13 years agoCleaned up m_getfld() code a bit. The most notable change
David Levine [Thu, 17 Jan 2013 02:13:04 +0000 (20:13 -0600)]
Cleaned up m_getfld() code a bit.  The most notable change
was to remove the check for mmdlm2 not being null.  It's
global data so that shouldn't happen.

13 years agoAdded check of a header with name that's 998 bytes long to
David Levine [Wed, 16 Jan 2013 04:56:33 +0000 (22:56 -0600)]
Added check of a header with name that's 998 bytes long to
test-header.

13 years agoRemoved the for-loop that was used to get a header field
David Levine [Wed, 16 Jan 2013 02:11:41 +0000 (20:11 -0600)]
Removed the for-loop that was used to get a header field
name in m_getfld ().  It was no longer necessary when not
drawing directly from the stdio buffer.

13 years agoCheck that a character array isn't empty before looking for its
David Levine [Wed, 16 Jan 2013 01:38:16 +0000 (19:38 -0600)]
Check that a character array isn't empty before looking for its
next-to-last element.

13 years agoIn build_nmh, removed configuration of pager and editor.
David Levine [Wed, 16 Jan 2013 00:14:46 +0000 (18:14 -0600)]
In build_nmh, removed configuration of pager and editor.
And replaced use of which(1) with a self-contained function.

13 years agoSupport the VISUAL and EDITOR environment variables, and remove support
Ken Hornstein [Tue, 15 Jan 2013 20:30:17 +0000 (15:30 -0500)]
Support the VISUAL and EDITOR environment variables, and remove support
for configuring a default editor with --with-editor.

13 years agoRemove the --with-pager configure option and replace it with a default
Ken Hornstein [Tue, 15 Jan 2013 18:22:13 +0000 (13:22 -0500)]
Remove the --with-pager configure option and replace it with a default
of "more".

13 years agoRenamed a couple of m_getfld auxiliary functions.
David Levine [Tue, 15 Jan 2013 04:05:38 +0000 (22:05 -0600)]
Renamed a couple of m_getfld auxiliary functions.

13 years agoCleaned up m_getfld's read_more().
David Levine [Tue, 15 Jan 2013 03:34:08 +0000 (21:34 -0600)]
Cleaned up m_getfld's read_more().

13 years agoIn m_getfld(), fixed the loop that handles the FLDPLUS case.
David Levine [Tue, 15 Jan 2013 03:05:22 +0000 (21:05 -0600)]
In m_getfld(), fixed the loop that handles the FLDPLUS case.
In Getc(), removed the increment of the byte count at EOF,
it didn't seem correct or necessary.

13 years agom_getfld() now supports interleaving calls with
David Levine [Tue, 15 Jan 2013 02:58:56 +0000 (20:58 -0600)]
m_getfld() now supports interleaving calls with
fseek()/ftell().  Reverted the changes to uip/mhparse.c of
commit 484eb1003ae647e4b751e4d7829c7daf44fb99c9 because
they're no longer necessary.

13 years agoMoved test of empty header field from
David Levine [Mon, 14 Jan 2013 15:45:23 +0000 (09:45 -0600)]
Moved test of empty header field from
test/inc/test-inc-scanout to test/bad-input/test-header.

13 years agoCleaned up a bit.
David Levine [Mon, 14 Jan 2013 15:41:50 +0000 (09:41 -0600)]
Cleaned up a bit.

13 years agoAdded support for m_getfld() callers interleaving fseek() calls
David Levine [Mon, 14 Jan 2013 03:56:07 +0000 (21:56 -0600)]
Added support for m_getfld() callers interleaving fseek() calls
with their m_getfld() calls.

13 years agoAdded bytes_read to m_getfld() buffer state. This is the
David Levine [Sun, 13 Jan 2013 17:08:28 +0000 (11:08 -0600)]
Added bytes_read to m_getfld() buffer state.  This is the
next step in supporting ftell()/fseek().

13 years agoRemoved unused local char_read from forwsbr.c.
David Levine [Sun, 13 Jan 2013 15:43:15 +0000 (09:43 -0600)]
Removed unused local char_read from forwsbr.c.

13 years agoAdded check of m_getfld() handling of fields with trailing
David Levine [Sun, 13 Jan 2013 15:17:47 +0000 (09:17 -0600)]
Added check of m_getfld() handling of fields with trailing
whitespace to test-inc-scanout.'

13 years agoRemoved "sleazy hack" of negative bufsz because commit
David Levine [Sat, 12 Jan 2013 17:14:45 +0000 (11:14 -0600)]
Removed "sleazy hack" of negative bufsz because commit
05d8af21d26673279a1ca079ad9c6f301426fe0e removed the only
use of it.

13 years agoCleaned up FLDPLUS handling in m_getfld(). As part of this,
David Levine [Sat, 12 Jan 2013 16:58:31 +0000 (10:58 -0600)]
Cleaned up FLDPLUS handling in m_getfld().  As part of this,
removed the backing up of the read pointer in the "something
went wrong" portion of the FLD handling.  It had been moved
back two positions.  The first is no longer necessary
because a Getc() was replace by a Peek(), and the second
caused the extra blank line noted in the old comments.
Updated the expected output in test/bad-input/test-header to
correspond.

13 years agoFixed addition to test-inc-scanout in
David Levine [Sat, 12 Jan 2013 15:23:19 +0000 (09:23 -0600)]
Fixed addition to test-inc-scanout in
683e0fb1a14da5b9ce7bc5db6e76951d14d79348 to not depend on
current date.

13 years agoVery minor cleanup to m_getfld() to remove an increment of j.
David Levine [Sat, 12 Jan 2013 15:21:59 +0000 (09:21 -0600)]
Very minor cleanup to m_getfld() to remove an increment of j.

13 years agoWe never use the autoconf checks for errno.h, crypt.h, or netdb.h, so
Ken Hornstein [Fri, 11 Jan 2013 16:13:44 +0000 (11:13 -0500)]
We never use the autoconf checks for errno.h, crypt.h, or netdb.h, so
remove them.

13 years agoAt this point we're assuming at least C89 support, so there's no reason
Ken Hornstein [Fri, 11 Jan 2013 16:07:51 +0000 (11:07 -0500)]
At this point we're assuming at least C89 support, so there's no reason
we should check for support for const and standard header files.

13 years agoStarted revising m_getfld() code to replace direct buffer
David Levine [Fri, 11 Jan 2013 04:52:59 +0000 (22:52 -0600)]
Started revising m_getfld() code to replace direct buffer
access with Getc().  The goal is to again support fseek()
after return from m_getfld().

13 years agoConvert the MIME content cache switches over to the smatch() New World Order.
Ken Hornstein [Thu, 10 Jan 2013 19:18:15 +0000 (14:18 -0500)]
Convert the MIME content cache switches over to the smatch() New World Order.

13 years agoAdded explicit third initializer to some swit struct values
David Levine [Thu, 10 Jan 2013 14:00:20 +0000 (08:00 -0600)]
Added explicit third initializer to some swit struct values
to silence gcc -Wmissing-field-initialziers warning.

13 years agoConvert all argument processing over to using X-Macros for cleanup.
Ken Hornstein [Thu, 10 Jan 2013 03:04:23 +0000 (22:04 -0500)]
Convert all argument processing over to using X-Macros for cleanup.
Based on a suggestion by Ralph Corderoy.

13 years agoAdded comments to and started cleaning up m_getfld.c.
David Levine [Thu, 10 Jan 2013 02:58:03 +0000 (20:58 -0600)]
Added comments to and started cleaning up m_getfld.c.

13 years agoWhen read_more() loads more bytes, save some from the end of the
David Levine [Thu, 10 Jan 2013 02:50:58 +0000 (20:50 -0600)]
When read_more() loads more bytes, save some from the end of the
current chunk and move them to the front of the buffer.  This
allows backing up of the current position, which is necessary when
looking for the message delimiter in a maildrop file.

13 years agoFix bug where a "cur" sequence that was outside the folder allocation limits
Ken Hornstein [Mon, 7 Jan 2013 22:41:27 +0000 (17:41 -0500)]
Fix bug where a "cur" sequence that was outside the folder allocation limits
could trigger a core dump on some systems.

13 years agoRemoved support for #ifdef LBL. It was broken anyways,
David Levine [Sun, 6 Jan 2013 21:04:24 +0000 (15:04 -0600)]
Removed support for #ifdef LBL.  It was broken anyways,
sometime between MH 6.8.5 and the Apr 1999 entry into CVS.
Also removed the addtoseq format function that could only be
accessed with it.

13 years agoFixed test-utf8-body to actually contain the UTF-8 character
David Levine [Sun, 6 Jan 2013 15:38:21 +0000 (09:38 -0600)]
Fixed test-utf8-body to actually contain the UTF-8 character
instead of the single byte, 8-bit character.  This was caught
using Heirloom shell with a UTF-8 locale:  when it wrote the
test draft from a here document, it converted the single byte
character to UTF-8.  This verifies that behavior:

LANG=en_US.utf-8 /usr/lib/heirloom/5bin/sh -c "od -x <<EOF
`printf '\xA1'`
EOF
"

13 years agoExpanded warning message for invalid Content-Transfer-Encoding.
David Levine [Sat, 5 Jan 2013 15:55:35 +0000 (09:55 -0600)]
Expanded warning message for invalid Content-Transfer-Encoding.

13 years agoAdded reference to RFC-1864 to mhbuild man page.
David Levine [Sat, 5 Jan 2013 00:50:06 +0000 (18:50 -0600)]
Added reference to RFC-1864 to mhbuild man page.

13 years agoRemove support for -ebcdicsafe/-noebcdicsafe switches in various utilities.
Ken Hornstein [Fri, 4 Jan 2013 20:12:15 +0000 (15:12 -0500)]
Remove support for -ebcdicsafe/-noebcdicsafe switches in various utilities.

13 years agoCreate a dependency for mh-chart.man on all of the man page sources so
Ken Hornstein [Fri, 4 Jan 2013 20:03:32 +0000 (15:03 -0500)]
Create a dependency for mh-chart.man on all of the man page sources so
it gets rebuilt correctly if the man pages change.

13 years agoBlock SIGPIPE before killing the child in sm_end(). This replaces
David Levine [Fri, 4 Jan 2013 04:33:42 +0000 (22:33 -0600)]
Block SIGPIPE before killing the child in sm_end().  This replaces
the discard() calls that were removed in commit 4548a3ecc4248a1d4.

13 years agoRemoved discard() call in post(8). It was only used with -debug
David Levine [Fri, 4 Jan 2013 04:32:28 +0000 (22:32 -0600)]
Removed discard() call in post(8).  It was only used with -debug
and seemed to serve no useful purpose any more.  Its comment
said that it was needed to help the loader.

13 years agoIn cpstripped() and cptrimmed(), if a multibyte character is
David Levine [Fri, 4 Jan 2013 03:59:44 +0000 (21:59 -0600)]
In cpstripped() and cptrimmed(), if a multibyte character is
found, only count it as taking up one character in the
destination buffer (if it has enought room).  This way,
scan(1)'s output won't be jagged if there are any subjects,
for example, that have multibyte characters.

Added a test for this to test-scan-multibyte, and moved the
test for an invalid multibyte sequence from test-scan to it.