(get_tags): Properly handle errors from metaflac.

[flac-archive] / flac2mp3

diff --git a/flac2mp3 b/flac2mp3
index 2231b1f8d23a58b98267e963a6c6647ba3b6824e..5a92c3c266ffef1d5a03ed329480c607698ca872 100755 (executable)
--- a/flac2mp3
+++ b/flac2mp3
@@ -75,7 +75,8 @@ sub get_tags {
     my $date;
     my @titles;
 
-    open(TAGS, '-|', 'metaflac', '--export-vc-to=-', $fn);
+    open(TAGS, '-|', 'metaflac', '--export-vc-to=-', $fn)
+      or die("open(metaflac --export-vc-to=- $fn): $!");
     while (<TAGS>) {
         chomp;
 
@@ -91,7 +92,7 @@ sub get_tags {
             push(@titles, $value);
         }
     }
-    close(TAGS) or die("close($fn): $!");
+    close(TAGS) or die("close(metaflac --export-vc-to=- $fn): $?");
 
     return ($artist, $album, $date, @titles);
 }
@@ -107,13 +108,15 @@ sub flac2mp3 {
     my $until_arg = shift;
 
     my $outfile = sprintf("$artist ($album) \%02s $title.mp3", $track);
-    $outfile =~ s/\//_/g;
-    $outfile =~ s/:/_/g;
-    $outfile =~ s/'/_/g;
-    $outfile =~ s/"/_/g;
+    for ($outfile) {
+        s/\//_/g;
+        s/:/_/g;
+        s/'/_/g;
+        s/"/_/g;
+    }
 
-    # XXX
     $until_arg ||= '';
+    # XXX
     system("flac -cd $skip_arg $until_arg '$fn' | lame --preset standard --tt '$title' --ta '$artist' --tl '$album' --ty '$date' --tn $track - '$outfile'");
 }