Add DISCNUMBER support.

[flac-archive] / flac2mp3

diff --git a/flac2mp3 b/flac2mp3
index 8c4e7462efc18e08e62d962b946d913e913f1c8b..ab83c9f9528110eeab7a55fcc6b7ba8e10d63ea0 100755 (executable)
--- a/flac2mp3
+++ b/flac2mp3
@@ -8,14 +8,14 @@ B<flac2mp3> - transcode FLAC file to MP3 files
 
 =head1 SYNOPSIS
 
 
 =head1 SYNOPSIS
 

-B<flac2mp3> I<file>
+B<flac2mp3> [B<--lame-options> I<lame-options>] [B<-q>] [B<-v>] I<file> [...]

 
 =head1 DESCRIPTION
 
 
 =head1 DESCRIPTION
 

-B<flac2mp3> transcodes the FLAC file I<file> to MP3 files.  I<file> is
-the kind of FLAC file B<fa-flacd> generates.  That is, it contains a
-cue sheet, one TITLE tag per track listed therein, and ARTIST, ALBUM,
-and DATE tags.
+B<flac2mp3> transcodes the FLAC files I<file> to MP3 files.  I<file>
+may be the kind of FLAC file B<fa-flacd> generates.  That is, it
+contains a cue sheet, one TITLE tag per track listed therein, and
+ARTIST, ALBUM, and DATE tags.

 
 =cut
 
 
 =cut
 


@@ -24,11 +24,18 @@ use warnings;
 
 use POSIX ':sys_wait_h';
 use Pod::Usage;
 
 use POSIX ':sys_wait_h';
 use Pod::Usage;

+use Getopt::Long qw(:config gnu_getopt no_ignore_case);
+
+my $flac_options;
+my $lame_options;
+my $quiet;
+my $verbose;

 
 sub run_or_die {
     my $command = shift;
     my $status;
 
 
 sub run_or_die {
     my $command = shift;
     my $status;
 

+    $verbose and print(STDERR "$command\n");

     $status = system($command);
 
     if (WIFEXITED($status)) {
     $status = system($command);
 
     if (WIFEXITED($status)) {


@@ -78,6 +85,11 @@ sub get_decode_args {
         push(@args, $arg);
     }
 
         push(@args, $arg);
     }
 

+    # If no cue sheet, stick a dummy in here.
+    if (@args == 0) {
+        @args = ([]);
+    }
+

     return @args;
 }
 
     return @args;
 }
 


@@ -85,12 +97,15 @@ sub get_decode_args {
 # in the file FN.
 sub get_tags {
     my $fn = shift;
 # in the file FN.
 sub get_tags {
     my $fn = shift;

+    my $artists = shift;
+    my $titles = shift;

     my $tag;
     my $value;
     my $artist;
     my $album;
     my $date;
     my $tag;
     my $value;
     my $artist;
     my $album;
     my $date;

-    my @titles;
+    my $discnum;
+    my $track;

 
     open(TAGS, '-|', 'metaflac', '--export-vc-to=-', $fn)
       or die("open(metaflac --export-vc-to=- $fn): $!");
 
     open(TAGS, '-|', 'metaflac', '--export-vc-to=-', $fn)
       or die("open(metaflac --export-vc-to=- $fn): $!");


@@ -99,19 +114,39 @@ sub get_tags {
 
         ($tag, $value) = split(/=/, $_, 2);
 
 
         ($tag, $value) = split(/=/, $_, 2);
 

-        if (/^ARTIST=/) {
+        if (/^ARTIST=/i) {

             $artist = $value;
             $artist = $value;

-        } elsif (/^ALBUM=/) {
+        } elsif (/^ALBUM=/i) {

             $album = $value;
             $album = $value;

-        } elsif (/^DATE=/) {
+        } elsif (/^DATE=/i) {

             $date = $value;
             $date = $value;

-        } elsif (/TITLE/) {
-            push(@titles, $value);
+        } elsif (/^DISCNUMBER=/i) {
+            $discnum = int($value);
+        } elsif (/^ARTIST\[/i) {
+            push(@$artists, $value);
+        } elsif (/^TRACKNUMBER=/i) {
+            $track = $value;
+
+        # Intentionally don't match the = on this one, to support the
+        # TITLE[1] .. TITLE[n] tag style.
+        } elsif (/^TITLE/i) {
+            push(@$titles, $value);

         }
     }
     close(TAGS) or die("close(metaflac --export-vc-to=- $fn): $?");
 
         }
     }
     close(TAGS) or die("close(metaflac --export-vc-to=- $fn): $?");
 

-    return ($artist, $album, $date, @titles);
+    return ($artist, $album, $date, $discnum, $track);
+}
+
+sub arg {
+    my $arg = shift;
+    my $var = shift;
+
+    if (defined($$var)) {
+        $$var = "$arg '$$var'";
+    } else {
+        $$var = ''
+    }

 }
 
 sub flac2mp3 {
 }
 
 sub flac2mp3 {


@@ -120,41 +155,109 @@ sub flac2mp3 {
     my $artist = shift;
     my $album = shift;
     my $date = shift;
     my $artist = shift;
     my $album = shift;
     my $date = shift;

-    my $track = shift;
+    my $track = int(shift);

     my $skip_arg = shift;
     my $until_arg = shift;
     my $skip_arg = shift;
     my $until_arg = shift;

+    my @tmp;

     my $outfile;
 
     my $outfile;
 

+    if ($quiet) {
+        $flac_options = '--silent';
+    } else {
+        $flac_options = '';
+    }
+
+    if ($lame_options) {
+        push(@tmp, $lame_options);
+    } else {
+        push(@tmp, '--preset standard');
+    }
+    $quiet and push(@tmp, '--quiet');
+    $verbose and push(@tmp, '--verbose');
+    $lame_options = join(' ', @tmp);
+

     # We'll be putting these in single quotes, so we need to escape
     # any single quotes in the filename by closing the quote ('),
     # putting an escaped quote (\'), and then reopening the quote (').
     for ($fn, $title, $artist, $album, $date) {
     # We'll be putting these in single quotes, so we need to escape
     # any single quotes in the filename by closing the quote ('),
     # putting an escaped quote (\'), and then reopening the quote (').
     for ($fn, $title, $artist, $album, $date) {

-        s/'/'\\''/;
+        defined and s/'/'\\''/g;

     }
 
     $outfile = sprintf("$artist ($album) \%02s $title.mp3", $track);
     $outfile =~ s/\//_/g;
 
     }
 
     $outfile = sprintf("$artist ($album) \%02s $title.mp3", $track);
     $outfile =~ s/\//_/g;
 

+    arg('--tt', \$title);
+    arg('--ta', \$artist);
+    arg('--tl', \$album);
+    arg('--ty', \$date);
+    arg('--tn', \$track);
+
+    $skip_arg ||= '';

     $until_arg ||= '';
     $until_arg ||= '';

-    run_or_die(join(' ', "flac -cd $skip_arg $until_arg '$fn'",
-                    " | lame --preset standard --tt '$title' --ta '$artist'",
-                    " --tl '$album' --ty '$date' --tn $track - '$outfile'"));
+    run_or_die(join(' ', "flac $flac_options -cd $skip_arg $until_arg '$fn'",
+                    " | lame $lame_options $title $artist $album $date $track",
+                    " - '$outfile'"));

 }
 
 MAIN: {
 }
 
 MAIN: {

-    my $fn = shift or pod2usage();
-    my @args = get_decode_args($fn);
-    my ($artist, $album, $date, @titles) = get_tags($fn);
-
-    for my $i (0..$#titles) {
-        flac2mp3($fn, $titles[$i], $artist, $album, $date, $i + 1,
-                 @{$args[$i]});
+    my $help;
+    GetOptions(
+               'lame-options=s', \$lame_options,
+               'quiet|q' => \$quiet,
+               'verbose|v' => \$verbose,
+               'help|h|?' => \$help,
+              ) or pod2usage();
+    $help and pod2usage(-exitstatus=>0, -verbose=>1);
+
+    @ARGV or pod2usage();
+    for my $fn (@ARGV) {
+        my @args = get_decode_args($fn);
+        my (@artists, @titles);
+        my ($artist, $album, $date, $discnum, $track) = get_tags($fn, \@artists,
+                                                                 \@titles);
+
+        # lame doesn't seem to support disc number.
+        defined($discnum) and $album .= " (disc $discnum)";
+
+        # Stupid hack: only a single-track file should have the
+        # TRACKNUMBER tag, so use it if set for the first pass through
+        # the loop.  At the end of the loop, we'll set $track for the
+        # next run, so this continues to work for multi-track files.
+        $track ||= 1;
+
+        for my $i (0..$#titles) {
+            flac2mp3($fn, $titles[$i], ($artists[$i] or $artist), $album, $date,
+                     $track, @{$args[$i]});
+            $track = $i + 2;
+        }

     }
 }
 
 \f
 __END__
 
     }
 }
 
 \f
 __END__
 

+=head1 OPTIONS
+
+=over 4
+
+=item B<--lame-options> I<lame-options>
+
+Pass I<lame-options> to B<lame>.  This ends up being passed to the
+shell, so feel free to take advantage of that.  You'll almost
+certainly have to put I<lame-options> in single quotes.
+
+=item B<-q> [B<--quiet>]
+
+Suppress status information.  This option is passed along to B<flac>
+and B<lame>.
+
+=item B<-v> [B<--verbose>]
+
+Print diagnostic information.  This option is passed along to B<flac>
+and B<lame>.
+
+=back
+

 =head1 AUTHORS
 
 Written by Eric Gillespie <epg@pretzelnet.org>.
 =head1 AUTHORS
 
 Written by Eric Gillespie <epg@pretzelnet.org>.