UNTESTED: Refactor the job parallelization stuff into a generic Jobs package.

[flac-archive] / fa-flacd

diff --git a/fa-flacd b/fa-flacd
index f2e20b780c5e471a1c4d9659ed723d3aaee55b82..b10e0c9c210a2f296f3f2ad03abe2f3ade417587 100755 (executable)
--- a/fa-flacd
+++ b/fa-flacd
@@ -13,6 +13,68 @@ B<fa-flacd> [B<-j> I<jobs>] [B<-v>]
 
 =cut
 
 
 =cut
 

+package Jobs;
+
+use strict;
+use warnings;
+
+use POSIX ':sys_wait_h';
+
+our @jobs;
+our @finished;
+
+sub reaper {
+    while ((my $pid = waitpid(-1, WNOHANG)) > 0) {
+        push(@finished, [$pid, $?]);
+    }
+
+    # XXX if $pid == -1 handle errors?
+
+    $SIG{CHLD} = \&reaper;
+}
+
+sub newjob {
+    my $f = shift;
+    my %o = @_;
+    my $pid;
+
+    $SIG{CHLD} = \&reaper;
+    if (not $o{'debug'}) {
+        $pid = fork();
+        if (not defined($pid)) {
+            die("fork: $!");
+        }
+    }
+
+    if ($o{'debug'} or $pid == 0) {
+        $SIG{CHLD} = 'DEFAULT';
+        exit($f->());
+    }
+
+    push(@jobs, $pid);
+
+    return $pid;
+}
+
+sub deljob {
+    my $i = shift;
+    my $j;
+
+    my ($pid, $status) = @{$finished[$i]};
+
+    for ($j = 0; $j <= $#jobs; $j++) {
+        $pid == $jobs[$j] and splice(@jobs, $j, 1) and last;
+    }
+
+    splice(@finished, $i, 1);
+
+    return ($pid, $status);
+}
+
+\f
+################################################################################
+package main;
+

 use strict;
 use warnings;
 
 use strict;
 use warnings;
 


@@ -23,8 +85,6 @@ use Pod::Usage;
 
 my $debug;
 my $verbose;
 
 my $debug;
 my $verbose;

-my @jobs;
-my @finished;

 
 sub verbose {
     $verbose and print(STDERR $_) for @_;
 
 sub verbose {
     $verbose and print(STDERR $_) for @_;


@@ -65,7 +125,7 @@ sub get_tags {
     return ($artist, $album, $discnum, @tags);
 }
 
     return ($artist, $album, $discnum, @tags);
 }
 

-sub bork_tags {
+sub track_tags {

     my $h = shift;
     my @result;
 
     my $h = shift;
     my @result;
 


@@ -151,45 +211,54 @@ sub flac {
         $outlog = "../$artist/$outfile.log";
         @files = ("$artist/$outfile.flac");
     } else {
         $outlog = "../$artist/$outfile.log";
         @files = ("$artist/$outfile.flac");
     } else {

-        my %things;
-        my @artist;
-        my @bork;
+        # Go over @tags, store all [n] tags in a list keyed by n in
+        # %tracks_to_tags, store all ARTIST (not ARTIST[n]) tags in
+        # @disc_artist, and leave the rest in @tags.
+        my %tracks_to_tags;
+        my @disc_artist;
+        my @tmp;

         for my $tag (@tags) {
             if ($tag =~ /^([^[]+)\[(\d+)]=(.*)/) {
         for my $tag (@tags) {
             if ($tag =~ /^([^[]+)\[(\d+)]=(.*)/) {

-                push(@{$things{$2}->{$1}}, $3);
+                push(@{$tracks_to_tags{$2}->{$1}}, $3);

             } elsif ($tag =~ /^ARTIST=/) {
             } elsif ($tag =~ /^ARTIST=/) {

-                push(@artist, $tag);
+                push(@disc_artist, $tag);

             } else {
             } else {

-                push(@bork, $tag);
+                push(@tmp, $tag);

             }
         }
             }
         }

-        @tags = @bork;
+        @tags = @tmp;

 
 

-        for my $tracknum (sort(map(int, keys(%things)))) {
-            my $title = join(' ', map(split, @{$things{$tracknum}->{'TITLE'}}));
+        for my $tracknum (sort(map(int, keys(%tracks_to_tags)))) {
+            my $title = join(' ', map(split, @{$tracks_to_tags{$tracknum}->{'TITLE'}}));

             $title =~ s|/|_|g;
             $title =~ s|/|_|g;

-            $outfile = join(' ',
-                            (defined($discnum)
-                             ? sprintf('%02d', $discnum)
-                             : ()),
-                            sprintf('%02d', $tracknum),
-                            $title);
-            push(@files, "$outdir/$outfile.flac");
-            $outfile = "../$outdir/$outfile";
-
-            my @lartist;
-            if (exists($things{$tracknum}->{'ARTIST'})) {
-                @lartist = ();
+            $outfile = join('/',
+                            $outdir,
+                            join(' ',
+                                 (defined($discnum)
+                                  ? sprintf('%02d', $discnum)
+                                  : ()),
+                                 sprintf('%02d', $tracknum),
+                                 $title));
+
+            # If we have ARTIST[n] tags for this track, set
+            # @track_artist to the empty list; they will go in along
+            # with the other [n] tags.
+            my @track_artist;
+            if (exists($tracks_to_tags{$tracknum}->{'ARTIST'})) {
+                @track_artist = ();

             } else {
             } else {

-                @lartist = @artist;
+                @track_artist = @disc_artist;

             }
 
             }
 

-            run_flac(sprintf('track%02d.cdda.wav', $tracknum), undef, $outfile,
-                     @lartist,
-                     grep({ $_ !~ /^ARTIST=/ } @tags),
-                     bork_tags($things{$tracknum}));
-            $outlog = "../$outdir/log";
+            run_flac(sprintf('track%02d.cdda.wav', $tracknum), undef,
+                     "../$outfile",
+                     @track_artist,
+                     @tags,
+                     "TRACKNUMBER=$tracknum",
+                     track_tags($tracks_to_tags{$tracknum}));
+            push(@files, "$outfile.flac");

         }
         }

+        $outlog = "../$outdir/log";

     }
 
     verbose("Cleaning up $dir\n");
     }
 
     verbose("Cleaning up $dir\n");


@@ -200,7 +269,7 @@ sub flac {
     chdir('..') or die("chdir(..): $!");
 
     if (-x "$dir/post-processor") {
     chdir('..') or die("chdir(..): $!");
 
     if (-x "$dir/post-processor") {

-        verbose(join(' ', 'Running', @files), "\n");
+        verbose(join(' ', "Running ./$dir/post-processor", @files), "\n");

         system("./$dir/post-processor", @files);
         unlink("$dir/post-processor") or die("unlink($dir/post-processor): $!");
     }
         system("./$dir/post-processor", @files);
         unlink("$dir/post-processor") or die("unlink($dir/post-processor): $!");
     }


@@ -210,79 +279,38 @@ sub flac {
     return 0;
 }
 
     return 0;
 }
 

-sub reaper {
-    my $pid;
-
-    while (($pid = waitpid(-1, WNOHANG)) > 0) {
-        push(@finished, [$pid, $?]);
-    }
-
-    $SIG{CHLD} = \&reaper;
-}
-
-sub newjob {
-    my $dir = shift;
-    my $pid;
-
-    if (not $debug) {
-        $pid = fork();
-        if (not defined($pid)) {
-            die("fork: $!");
-        }
-    }
-
-    if ($debug or $pid == 0) {
-        $SIG{CHLD} = 'DEFAULT';
-        open(STDERR, ">$dir/log") or die("open(STDERR, >$dir/log): $!");
-        exit(flac($dir));
-    }
-
-    verbose("new job $pid for $dir\n");
-    return $pid;
-}
-
-sub deljob {
-    my $i = shift;
-    my $j;
-    my $pid;
-    my $status;
-
-    $pid = $finished[$i][0];
-    $status = $finished[$i][1];
-
-    verbose("$pid finished (");
-    if (WIFEXITED($status)) {
-        verbose('exited with status ', WEXITSTATUS($status));
-    } elsif (WIFSIGNALED($status)) {
-        verbose('killed with signal ', WTERMSIG($status));
-    } elsif (WIFSTOPPED($status)) {
-        verbose('stopped with signal ', WSTOPSIG($status));
-    }
-    verbose(")\n");
-
-    for ($j = 0; $j <= $#jobs; $j++) {
-        $pid == $jobs[$j] and splice(@jobs, $j, 1) and last;
-    }
-
-    splice(@finished, $i, 1);
-}
-

 sub flacloop {
     my $MAXJOBS = shift;
     my $i;
 sub flacloop {
     my $MAXJOBS = shift;
     my $i;

-    my $j;

 
 
     $SIG{CHLD} = \&reaper;
     while (1) {
         if (scalar(@jobs) <= $MAXJOBS) {
             foreach $i (glob('*/tags')) {
 
 
     $SIG{CHLD} = \&reaper;
     while (1) {
         if (scalar(@jobs) <= $MAXJOBS) {
             foreach $i (glob('*/tags')) {

-                push(@jobs, newjob(dirname($i))) <= $MAXJOBS or last;
+                my $dir = dirname($i);
+                my $pid =
+                  Jobs::newjob(sub {
+                                   open(STDERR, ">$dir/log")
+                                     or die("open(STDERR, >$dir/log): $!");
+                                   return flac($dir);
+                               }, 'debug'=>$debug);
+                verbose("new job $pid for $dir\n");
+                @Jobs::jobs <= $MAXJOBS or last;

             }
         }
 
         for ($i = 0; $i <= $#finished; $i++) {
             }
         }
 
         for ($i = 0; $i <= $#finished; $i++) {

-            deljob($i);
+            my ($pid, $status) = Jobs::deljob($i);
+            verbose("$pid finished (");
+            if (WIFEXITED($status)) {
+                verbose('exited with status ', WEXITSTATUS($status));
+            } elsif (WIFSIGNALED($status)) {
+                verbose('killed with signal ', WTERMSIG($status));
+            } elsif (WIFSTOPPED($status)) {
+                verbose('stopped with signal ', WSTOPSIG($status));
+            }
+            verbose(")\n");

         }
 
         verbose(scalar(@jobs), " jobs\n");
         }
 
         verbose(scalar(@jobs), " jobs\n");